Skip to content

ci: add demo build for Rocky Linux 9#10215

Merged
coryan merged 2 commits intogoogleapis:mainfrom
coryan:ci-create-demo-rockylinux-9-builds
Nov 9, 2022
Merged

ci: add demo build for Rocky Linux 9#10215
coryan merged 2 commits intogoogleapis:mainfrom
coryan:ci-create-demo-rockylinux-9-builds

Conversation

@coryan
Copy link
Copy Markdown
Contributor

@coryan coryan commented Nov 9, 2022 •
edited
Loading

Fixes #10124

This change is Reviewable

@google-cloud-cpp-bot
Copy link
Copy Markdown
Contributor

google-cloud-cpp-bot commented Nov 9, 2022

Google Cloud Build Logs
For commit: 549c7187050c797ed8aa5da35fa8c633e578f9f7

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 9, 2022 •
edited
Loading

Codecov Report

Base: 93.97% // Head: 93.98% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (549c718) compared to base (6ba8928).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #10215   +/-   ##
=======================================
  Coverage   93.97%   93.98%           
=======================================
  Files        1532     1532           
  Lines      141103   141103           
=======================================
+ Hits       132608   132611    +3     
+ Misses       8495     8492    -3
Impacted Files Coverage Δ
google/cloud/bigtable/async_read_stream_test.cc 97.32% <0.00%> (-0.67%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 98.65% <0.00%> (+0.50%) ⬆️
google/cloud/pubsub/subscriber_connection_test.cc 98.36% <0.00%> (+0.54%) ⬆️
...integration_tests/schema_admin_integration_test.cc 100.00% <0.00%> (+1.11%) ⬆️
...e/cloud/pubsublite/internal/alarm_registry_impl.cc 100.00% <0.00%> (+2.94%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan marked this pull request as ready for review November 9, 2022 18:08
@coryan coryan requested a review from a team November 9, 2022 18:08
devbww
devbww reviewed Nov 9, 2022
View reviewed changes
Comment thread ci/cloudbuild/builds/lib/quickstart.sh Outdated
Comment on lines +82 to +83
io::run env PKG_CONFIG_PATH="${prefix}/lib64/pkgconfig:${prefix}/lib/pkgconfig:${PKG_CONFIG_PATH:-}" pkg-config google_cloud_cpp_bigquery --libs
io::run env PKG_CONFIG_PATH="${prefix}/lib64/pkgconfig:${prefix}/lib/pkgconfig:${PKG_CONFIG_PATH:-}" pkg-config google_cloud_cpp_bigquery
Copy link
Copy Markdown
Contributor

@devbww devbww Nov 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bigquery-specific stuff looks out of place?

Copy link
Copy Markdown
Contributor Author

@coryan coryan Nov 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops, sorry, that was debugging. Removed now.

@google-cloud-cpp-bot
Copy link
Copy Markdown
Contributor

google-cloud-cpp-bot commented Nov 9, 2022

Google Cloud Build Logs
For commit: 4cb34c06826445d162c6b1aa51b6af81924c1de6

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan merged commit 2ae1f55 into googleapis:main Nov 9, 2022
@coryan coryan deleted the ci-create-demo-rockylinux-9-builds branch November 9, 2022 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@devbww devbww devbww approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create a demo-* build for RockyLinux 9

3 participants

@coryan @google-cloud-cpp-bot @devbww