Skip to content

Conversation

@coryan
Copy link
Contributor

@coryan coryan commented Nov 17, 2022

These will make it easier to return errors, with less syntactic noise. A future PR will make it easier to create error infos used in the library.

Motivated by #5915


This change is Reviewable

These will make it easier to return errors, with less syntactic noise.
A future PR will make it easier to create error infos used in the
library.
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 2f4cb5f8d5f6580b447ae66debad79c0f7c9820e

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Base: 93.81% // Head: 93.82% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (b1ce6b3) compared to base (29ffdb9).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10270   +/-   ##
=======================================
  Coverage   93.81%   93.82%           
=======================================
  Files        1565     1567    +2     
  Lines      143754   143798   +44     
=======================================
+ Hits       134863   134914   +51     
+ Misses       8891     8884    -7     
Impacted Files Coverage Δ
google/cloud/internal/make_status.cc 100.00% <100.00%> (ø)
google/cloud/internal/make_status_test.cc 100.00% <100.00%> (ø)
google/cloud/completion_queue_test.cc 97.13% <0.00%> (-0.20%) ⬇️
google/cloud/storage/parallel_upload.cc 98.62% <0.00%> (+0.34%) ⬆️
...torage/examples/storage_service_account_samples.cc 97.64% <0.00%> (+0.58%) ⬆️
...cloud/pubsub/internal/subscription_session_test.cc 98.65% <0.00%> (+0.67%) ⬆️
...integration_tests/schema_admin_integration_test.cc 100.00% <0.00%> (+1.11%) ⬆️
google/cloud/internal/random_test.cc 100.00% <0.00%> (+3.70%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan marked this pull request as ready for review November 18, 2022 00:39
@coryan coryan requested a review from a team as a code owner November 18, 2022 00:39
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: b1ce6b3967c23a99db40acc6cb0d3dd7f18b6a6e

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan merged commit 57823e0 into googleapis:main Nov 18, 2022
@coryan coryan deleted the feat-oauth2-workload-identity-federation-pr5 branch November 18, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants