Skip to content

Conversation

@coryan
Copy link
Contributor

@coryan coryan commented Nov 18, 2022

Motivated by #5915


This change is Reviewable

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 6e94f9ab7875b5b1bd0449de168b97c15b39d79a

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Base: 93.82% // Head: 93.82% // No change to project coverage 👍

Coverage data is based on head (98e6839) compared to base (98e6839).
Patch has no changes to coverable lines.

❗ Current head 98e6839 differs from pull request most recent head 6e94f9a. Consider uploading reports for the commit 6e94f9a to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10271   +/-   ##
=======================================
  Coverage   93.82%   93.82%           
=======================================
  Files        1570     1570           
  Lines      143816   143816           
=======================================
  Hits       134930   134930           
  Misses       8886     8886           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@coryan coryan marked this pull request as ready for review November 18, 2022 18:50
@coryan coryan requested a review from a team as a code owner November 18, 2022 18:50
Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @coryan)


google/cloud/internal/make_status_test.cc line 135 at r1 (raw file):

}

TEST(MakeStatus, WithErrorInfo) {

I'm curious why not use gTest's INSTANTIATE_TEST_P to do these parameterized tests?

Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @coryan)

Copy link
Contributor Author

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @scotthart)


google/cloud/internal/make_status_test.cc line 135 at r1 (raw file):

Previously, scotthart (Scott Hart) wrote…

I'm curious why not use gTest's INSTANTIATE_TEST_P to do these parameterized tests?

I keep that at the bottom of the toolbox. For not particular reason.

@coryan coryan enabled auto-merge (squash) November 18, 2022 19:05
@coryan coryan disabled auto-merge November 18, 2022 19:48
@coryan coryan enabled auto-merge (squash) November 18, 2022 19:55
@coryan coryan merged commit ba56822 into googleapis:main Nov 18, 2022
@coryan coryan deleted the feat-oauth2-workload-identity-federation-pr3.5 branch November 18, 2022 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants