-
Notifications
You must be signed in to change notification settings - Fork 433
impl(common): helpers to create ErrorInfo #10271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
impl(common): helpers to create ErrorInfo #10271
Conversation
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov ReportBase: 93.82% // Head: 93.82% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #10271 +/- ##
=======================================
Coverage 93.82% 93.82%
=======================================
Files 1570 1570
Lines 143816 143816
=======================================
Hits 134930 134930
Misses 8886 8886 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
scotthart
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @coryan)
google/cloud/internal/make_status_test.cc line 135 at r1 (raw file):
} TEST(MakeStatus, WithErrorInfo) {
I'm curious why not use gTest's INSTANTIATE_TEST_P to do these parameterized tests?
scotthart
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @coryan)
coryan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @scotthart)
google/cloud/internal/make_status_test.cc line 135 at r1 (raw file):
Previously, scotthart (Scott Hart) wrote…
I'm curious why not use gTest's INSTANTIATE_TEST_P to do these parameterized tests?
I keep that at the bottom of the toolbox. For not particular reason.
Motivated by #5915
This change is