impl(GCS+gRPC): InsertObjectRequest for AsyncClient#12503
Merged
coryan merged 1 commit intogoogleapis:mainfrom Aug 31, 2023
Merged
impl(GCS+gRPC): InsertObjectRequest for AsyncClient#12503coryan merged 1 commit intogoogleapis:mainfrom
InsertObjectRequest for AsyncClient#12503coryan merged 1 commit intogoogleapis:mainfrom
Conversation
We need a class to represent requests that insert objects via the `AsyncClient`. We cannot use the class from the synchronous client because that uses non-owning types for the data payload. And we also want the class in the public API (eventually) as it is needed for mocking.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #12503 +/- ##
=======================================
Coverage 93.62% 93.62%
=======================================
Files 2043 2043
Lines 180866 180935 +69
=======================================
+ Hits 169342 169408 +66
- Misses 11524 11527 +3
☔ View full report in Codecov by Sentry. |
devbww
approved these changes
Aug 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need a class to represent requests that insert objects via the
AsyncClient. We cannot use the class from the synchronous client because that uses non-owning types for the data payload. And we also want the class in the public API (eventually) as it is needed for mocking.Part of the work for #9131
This change is