-
Notifications
You must be signed in to change notification settings - Fork 433
feat(otel): GA for cmake #12735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(otel): GA for cmake #12735
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12735 +/- ##
=======================================
Coverage 93.58% 93.58%
=======================================
Files 2075 2075
Lines 183586 183586
=======================================
+ Hits 171806 171809 +3
+ Misses 11780 11777 -3 ☔ View full report in Codecov by Sentry. |
| list(REMOVE_ITEM GOOGLE_CLOUD_CPP_ENABLE experimental-opentelemetry) | ||
| list(INSERT GOOGLE_CLOUD_CPP_ENABLE 0 opentelemetry) | ||
| endif () | ||
| if (opentelemetry IN_LIST GOOGLE_CLOUD_CPP_ENABLE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we include opentelemetry in GOOGLE_CLOUD_CPP_GA_LIBRARIES? I think we should.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- If we were to do this, s/GA/TRANSITION/
- It would take some modifications. e.g. there is no mocks library
Lines 89 to 98 in f251ffc
[cc_library( name = "{library}_mocks".format(library = library), testonly = True, deps = [ "//google/cloud/{library_dir}:google_cloud_cpp_{library}_mocks".format( library = library, library_dir = google_cloud_cpp_library_dir_name(library), ), ], ) for library in GA_LIBRARIES + TRANSITION_LIBRARIES]
This may simplify things though. I will experiment.
coryan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to merge as-is while you experiment with a better alternative.
Part of the work for #12726
I think we need to wait until our vcpkg port has been updated before changing that part of the docs:
google-cloud-cpp/google/cloud/opentelemetry/quickstart/README.md
Line 168 in f251ffc
This change is