Skip to content

Conversation

@dbolduc
Copy link
Member

@dbolduc dbolduc commented Sep 27, 2023

Part of the work for #12726

I think we need to wait until our vcpkg port has been updated before changing that part of the docs:

./vcpkg install google-cloud-cpp[core,experimental-opentelemetry,storage]


This change is Reviewable

@dbolduc dbolduc temporarily deployed to internal September 27, 2023 05:30 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (f251ffc) 93.58% compared to head (269a29d) 93.58%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12735   +/-   ##
=======================================
  Coverage   93.58%   93.58%           
=======================================
  Files        2075     2075           
  Lines      183586   183586           
=======================================
+ Hits       171806   171809    +3     
+ Misses      11780    11777    -3     

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbolduc dbolduc marked this pull request as ready for review September 27, 2023 06:45
@dbolduc dbolduc requested a review from a team as a code owner September 27, 2023 06:45
list(REMOVE_ITEM GOOGLE_CLOUD_CPP_ENABLE experimental-opentelemetry)
list(INSERT GOOGLE_CLOUD_CPP_ENABLE 0 opentelemetry)
endif ()
if (opentelemetry IN_LIST GOOGLE_CLOUD_CPP_ENABLE)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we include opentelemetry in GOOGLE_CLOUD_CPP_GA_LIBRARIES? I think we should.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. If we were to do this, s/GA/TRANSITION/
  2. It would take some modifications. e.g. there is no mocks library
    [cc_library(
    name = "{library}_mocks".format(library = library),
    testonly = True,
    deps = [
    "//google/cloud/{library_dir}:google_cloud_cpp_{library}_mocks".format(
    library = library,
    library_dir = google_cloud_cpp_library_dir_name(library),
    ),
    ],
    ) for library in GA_LIBRARIES + TRANSITION_LIBRARIES]

This may simplify things though. I will experiment.

Copy link
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge as-is while you experiment with a better alternative.

@dbolduc dbolduc merged commit 885b2b3 into googleapis:main Sep 27, 2023
@dbolduc dbolduc deleted the otel-ga-cmake branch September 27, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants