Skip to content

Conversation

@mpeddada1
Copy link
Collaborator

@mpeddada1 mpeddada1 commented Oct 22, 2025

We won't need the empty prepared_query once #15650 is merged.

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Oct 22, 2025
@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

❌ Patch coverage is 81.29496% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.11%. Comparing base (f149191) to head (d7d3c03).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
generator/internal/scaffold_generator.cc 0.00% 14 Missing ⚠️
google/cloud/bigtable/data_connection.cc 0.00% 7 Missing ⚠️
...le/cloud/bigtable/internal/data_connection_impl.cc 57.14% 3 Missing ⚠️
google/cloud/bigtable/bound_query_test.cc 96.07% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main   #15651    +/-   ##
========================================
  Coverage   93.10%   93.11%            
========================================
  Files        2433     2439     +6     
  Lines      223834   223968   +134     
========================================
+ Hits       208402   208539   +137     
+ Misses      15432    15429     -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mpeddada1
Copy link
Collaborator Author

The compilation error is about unused parameters since the method only returns kUnimplemented at the moment.

@mpeddada1 mpeddada1 marked this pull request as ready for review October 22, 2025 22:50
@mpeddada1 mpeddada1 requested a review from a team as a code owner October 22, 2025 22:50
@mpeddada1 mpeddada1 merged commit a1c2b09 into googleapis:main Oct 27, 2025
66 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants