-
Notifications
You must be signed in to change notification settings - Fork 432
feat(bigtable): implement PrepareQuery in DataConnectionImpl #15661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15661 +/- ##
==========================================
- Coverage 93.11% 93.10% -0.01%
==========================================
Files 2439 2439
Lines 224091 224136 +45
==========================================
+ Hits 208655 208680 +25
- Misses 15436 15456 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
On the other hand, the |
| } | ||
| auto response = google::cloud::internal::RetryLoop( | ||
| retry_policy(*current), backoff_policy(*current), | ||
| Idempotency::kNonIdempotent, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should check with the Bigtable team to see if we're correct in treating this RPC as non-idempotent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm that's a good point, will confirm if this the desired behavior (created #15663 for an immediate follow up)
Introducing implementation to create a PreparedQuery through DataConnectionImpl#PrepareQuery.