-
Notifications
You must be signed in to change notification settings - Fork 432
feat(bigtable): add IT for querying multiple columns and rows #15737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…cpp into query-support-it
…cpp into query-support-it
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15737 +/- ##
==========================================
- Coverage 93.05% 93.03% -0.03%
==========================================
Files 2445 2445
Lines 225986 226034 +48
==========================================
- Hits 210297 210284 -13
- Misses 15689 15750 +61 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| std::map<std::string, std::pair<std::string, std::string>> expected_values; | ||
| expected_values[row_key1] = {value11, value12}; | ||
| expected_values[row_key2] = {value21, value22}; | ||
| for (auto const& row_status : rows) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I want to verify with this test is using StreamOf to read the rows. So let's change the for loop to look something like:
using RowType = std::tuple<std::string, std::string, std::string>;
std::vector<RowType> rows;
for (auto& row : StreamOf<RowType>(row_stream)) {
ASSERT_STATUS_OK(row);
rows.push_back(std::move(row));
}
EXPECT_THAT(rows, UnorderedElementsAre(RowType(), RowType("multi-column-query-row-1", "v11", "v12),
RowType("multi-column-query-row-2", "v21", "v22")));
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest of these ASSERT/EXPECTS can be skipped after adding the above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it! This really helps in cleaning up the assertions too, thanks.
No description provided.