impl(bigtable): add response accessor to PreparedQuery

[scotthart]

Adding PreparedQuery::response provides a mechanism to get metadata that may have changed due to a Query Plan refresh.

[gemini-code-assist]

Summary of Changes

Hello @scotthart, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Bigtable client library by introducing a mechanism to access the PrepareQueryResponse directly from PreparedQuery and BoundQuery objects. This allows applications to retrieve critical metadata, especially in scenarios where query plans might be refreshed, ensuring users have access to the most current information.

Highlights

• New Response Accessor: Added a response() accessor method to both PreparedQuery and BoundQuery classes.
• Metadata Access: This new accessor provides a StatusOr<google::bigtable::v2::PrepareQueryResponse> to retrieve metadata that may be subject to change due to Query Plan refreshes.
• Implementation: The PreparedQuery::response() implementation delegates the call to the underlying query_plan_ object.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a response() accessor to both PreparedQuery and BoundQuery classes. This allows users to access the PrepareQueryResponse, which is particularly useful for retrieving metadata that can change when a query plan is refreshed. The implementation correctly delegates the call to the underlying QueryPlan object.

My review includes a suggestion to clarify the comment for BoundQuery::response() to make it more accurate within its context.

Additionally, I noticed that while bound_query_test.cc includes tests for the new BoundQuery::response() method, there don't seem to be corresponding tests for PreparedQuery::response() in prepared_query_test.cc. It would be good to add tests to ensure the new functionality is covered for PreparedQuery as well.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.94%. Comparing base (0f0a7cf) to head (05df5e8).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
google/cloud/bigtable/prepared_query.cc	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #15769      +/-   ##
==========================================
- Coverage   92.95%   92.94%   -0.01%     
==========================================
  Files        2448     2448              
  Lines      226434   226436       +2     
==========================================
- Hits       210483   210467      -16     
- Misses      15951    15969      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.