Skip to content

Conversation

@mpeddada1
Copy link
Collaborator

No description provided.

@gemini-code-assist
Copy link

Summary of Changes

Hello @mpeddada1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a core dependency update for googleapis, which necessitated a widespread regeneration of several Google Cloud client libraries. The update introduces a new ExportArtifact functionality within the Artifact Registry client and includes numerous googleapis_reference_link adjustments across multiple services. A significant change is the deprecation of the GKE Multi-Cloud AWS and Azure cluster clients, signaling a shift in their long-term support or recommended usage.

Highlights

  • Dependency Update: The googleapis dependency has been updated to a newer SHA (05f65958eb7f2a8bc59db87ad40487f0fb093097), affecting its integrity hash, strip prefix, and URL across Bazel and CMake configurations.
  • New Feature: Artifact Registry ExportArtifact: A new ExportArtifact method has been introduced to the Artifact Registry client (ArtifactRegistryClient), complete with corresponding implementations in connection, stub, and decorator layers, as well as mock definitions.
  • Client Library Regeneration: Numerous googleapis_reference_link line numbers have been updated across several client libraries, including Channel, DLP, GKE Multi-Cloud (Attached, AWS, Azure), Parallelstore, Pub/Sub, and Run, indicating a broad regeneration due to the googleapis update.
  • GKE Multi-Cloud Client Deprecation: The AwsClustersClient and AzureClustersClient classes, along with all their associated methods, have been marked as deprecated in the GKE Multi-Cloud client library.
  • Pub/Sub Parameter Clarification: Parameter descriptions for various methods in the Pub/Sub Subscription and Topic Admin clients have been updated to explicitly include 'Identifier.' for resource names.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the googleapis dependency, which introduces a new ExportArtifact RPC for the Artifact Registry service and deprecates the GKE Multi-Cloud AwsClusters and AzureClusters clients. The changes are mostly generated code.

I've found a critical issue in the generated code for the new ExportArtifact RPC. The routing logic in the metadata decorator is incorrect, which will likely cause all calls to this new RPC to fail. It seems to be using a non-existent field for routing instead of the correct one specified in the API definition. Please see my detailed comments.

Comment on lines +661 to +663
SetMetadata(
*context, *options,
absl::StrCat("repository=", internal::UrlEncode(request.repository())));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The routing logic for AsyncExportArtifact appears to be incorrect. The ExportArtifactRequest message does not have a repository field, and the google.api.routing annotation specifies routing on the name field. This will cause RPCs to fail. The code should use request.name() to set the name routing parameter.

  SetMetadata(
      *context, *options,
      absl::StrCat("name=", internal::UrlEncode(request.name())));

Comment on lines +673 to +675
SetMetadata(
context, options,
absl::StrCat("repository=", internal::UrlEncode(request.repository())));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Similar to the async version, the routing logic for ExportArtifact is incorrect. It should use the name field from the request for routing, not a non-existent repository field.

  SetMetadata(
      context, options,
      absl::StrCat("name=", internal::UrlEncode(request.name())));

@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.94%. Comparing base (c08a8b3) to head (5deb225).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15827      +/-   ##
==========================================
- Coverage   92.95%   92.94%   -0.02%     
==========================================
  Files        2458     2458              
  Lines      227588   227588              
==========================================
- Hits       211562   211538      -24     
- Misses      16026    16050      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mpeddada1 mpeddada1 enabled auto-merge (squash) December 12, 2025 18:19
@mpeddada1 mpeddada1 merged commit 18c06b5 into googleapis:main Dec 12, 2025
65 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants