-
Notifications
You must be signed in to change notification settings - Fork 432
chore: update googleapis sha circa 2025 12 12 #15827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update googleapis sha circa 2025 12 12 #15827
Conversation
PiperOrigin-RevId: 843338117
Summary of ChangesHello @mpeddada1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a core dependency update for Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the googleapis dependency, which introduces a new ExportArtifact RPC for the Artifact Registry service and deprecates the GKE Multi-Cloud AwsClusters and AzureClusters clients. The changes are mostly generated code.
I've found a critical issue in the generated code for the new ExportArtifact RPC. The routing logic in the metadata decorator is incorrect, which will likely cause all calls to this new RPC to fail. It seems to be using a non-existent field for routing instead of the correct one specified in the API definition. Please see my detailed comments.
| SetMetadata( | ||
| *context, *options, | ||
| absl::StrCat("repository=", internal::UrlEncode(request.repository()))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The routing logic for AsyncExportArtifact appears to be incorrect. The ExportArtifactRequest message does not have a repository field, and the google.api.routing annotation specifies routing on the name field. This will cause RPCs to fail. The code should use request.name() to set the name routing parameter.
SetMetadata(
*context, *options,
absl::StrCat("name=", internal::UrlEncode(request.name())));| SetMetadata( | ||
| context, options, | ||
| absl::StrCat("repository=", internal::UrlEncode(request.repository()))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15827 +/- ##
==========================================
- Coverage 92.95% 92.94% -0.02%
==========================================
Files 2458 2458
Lines 227588 227588
==========================================
- Hits 211562 211538 -24
- Misses 16026 16050 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.