impl(v3): decommission PublisherOptions and SubscriberOptions

[scotthart]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @scotthart, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request completes the decommissioning of the legacy pubsub::PublisherOptions and pubsub::SubscriberOptions classes. By migrating all Pub/Sub client configuration to the google::cloud::Options class, the API becomes more consistent and streamlined, aligning with the broader google-cloud-cpp library's v3 design principles. This change simplifies client setup and reduces API surface area by centralizing option management.

Highlights

• Removal of Deprecated Options Classes: The pubsub::PublisherOptions and pubsub::SubscriberOptions classes, previously marked as deprecated, have been completely removed from the codebase.
• Standardized Configuration with google::cloud::Options: All configuration for Pub/Sub publishers and subscribers now exclusively uses the google::cloud::Options class, promoting a unified approach to client configuration across the google-cloud-cpp library.
• Migration Guide Updates: The doc/v3-migration-guide.md has been updated with comprehensive instructions, including detailed mappings from the old options methods to their new google::cloud::Options equivalents, along with 'Before' and 'After' code examples to aid migration.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request successfully removes the deprecated PublisherOptions and SubscriberOptions classes, migrating their functionality to google::cloud::Options. The changes correctly update the C++ code to use the new options mechanism and remove the old header files. The migration guide has been updated to reflect these changes, providing clear mapping tables and code examples for users transitioning to the new API. However, there are a few minor corrections needed in the migration guide's code examples to ensure accuracy and prevent potential compilation issues for users.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.84%. Comparing base (d8fe957) to head (acc7547).
⚠️ Report is 2 commits behind head on prepare-for-v3.0.0.

Additional details and impacted files

@@                  Coverage Diff                   @@
##           prepare-for-v3.0.0   #15891      +/-   ##
======================================================
- Coverage               92.84%   92.84%   -0.01%     
======================================================
  Files                    2391     2385       -6     
  Lines                  218505   218233     -272     
======================================================
- Hits                   202881   202616     -265     
+ Misses                  15624    15617       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.