Ci gha v3 windows3 by scotthart · Pull Request #15924 · googleapis/google-cloud-cpp

scotthart · 2026-01-31T01:25:39Z

This change is

gemini-code-assist · 2026-01-31T01:26:05Z

Summary of Changes

Hello @scotthart, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly upgrades and refines the Continuous Integration (CI) infrastructure, with a particular focus on Windows builds. It modernizes the dependency management by updating vcpkg and deeply integrating the OpenTelemetry C++ library, ensuring builds consistently use C++17. The changes address specific platform compatibility issues and streamline the process of incorporating external libraries, leading to more robust and reliable CI pipelines.

Highlights

Vcpkg and OpenTelemetry Updates: The vcpkg baseline has been updated to a newer commit, and the OpenTelemetry C++ library integration has been significantly enhanced through new vcpkg overlay ports. This includes updating the OpenTelemetry Protocol (OTLP) version to 1.6.0 and adding new features like otlp-file and opentracing.
C++17 Standardization: The build process now explicitly enforces the C++17 standard across various CMake configurations, replacing previous C++14 settings. This ensures modern C++ features are utilized and consistent compilation standards are maintained.
Windows Build Improvements: Specific fixes and configurations have been applied to improve Windows builds. This includes adding -DNOMINMAX to prevent macro conflicts, adjusting path separators for vcpkg overlay ports, and ensuring proper OpenTracing linking on Windows platforms.
New Vcpkg Manifests: New vcpkg.json and portfile.cmake files have been introduced for opentelemetry-cpp within the vcpkg overlay directories for both GitHub Actions and Kokoro CI, standardizing its dependency management and feature definitions.

Ignored Files

Ignored by pattern: .github/workflows/** (2)
- .github/workflows/test-runner.yml
- .github/workflows/windows-cmake.yml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request updates the CI/CD configuration for Windows builds, primarily focusing on vcpkg and OpenTelemetry-CPP. Key changes include setting C++17 as the standard, updating vcpkg versions and SHA hashes, and introducing new features and fixes for OpenTelemetry-CPP dependencies. The changes improve Windows compatibility and dependency management.

gemini-code-assist · 2026-01-31T01:28:27Z

CMakeLists.txt

 endif ()

+if (WIN32)
+    add_definitions(-DNOMINMAX)


Adding -DNOMINMAX is a crucial step for Windows compatibility in C++ projects. This prevents conflicts between the min/max macros defined in windows.h and std::min/std::max from the C++ standard library, which can lead to unexpected compilation errors or behavior.

gemini-code-assist · 2026-01-31T01:28:27Z

ci/gha/builds/lib/cmake.sh

    args+=("-DVCPKG_TARGET_TRIPLET=${VCPKG_TRIPLET}")
  fi
-  args+=("-DVCPKG_OVERLAY_PORTS=ci/gha/builds/vcpkg-overlays")
+  args+=("-DVCPKG_OVERLAY_PORTS=ci\gha\builds\vcpkg-overlays")


Changing the path separator from / to \ for VCPKG_OVERLAY_PORTS is essential for correct functionality on Windows systems, as Windows uses backslashes for directory paths. This ensures that vcpkg can correctly locate the overlay ports.

gemini-code-assist · 2026-01-31T01:28:27Z

ci/gha/builds/lib/cmake.sh

  fi
  local args
  args=(
+    -DCMAKE_CXX_STANDARD=17


Setting CMAKE_CXX_STANDARD to 17 explicitly ensures that the project is built with C++17 features. This is a good practice for modern C++ development and aligns with the repository's stated support for C++14 as a minimum version, effectively upgrading the standard used in this build configuration.

References

The repository style guide states that C++14 is the minimum supported C++ standard version. Upgrading to C++17 is a positive step towards modern C++ practices. ^(link)

gemini-code-assist · 2026-01-31T01:28:27Z

ci/gha/builds/vcpkg-overlays/opentelemetry-cpp/portfile.cmake

        "-DgRPC_CPP_PLUGIN_EXECUTABLE=${CURRENT_HOST_INSTALLED_DIR}/tools/grpc/grpc_cpp_plugin${VCPKG_HOST_EXECUTABLE_SUFFIX}"
    )
 endif ()
+list(APPEND FEATURE_OPTIONS -DCMAKE_CXX_STANDARD=17 -DWITH_STL=CXX17)


Explicitly setting CMAKE_CXX_STANDARD=17 and WITH_STL=CXX17 ensures consistency in the C++ standard used for the OpenTelemetry-CPP port. This aligns with modern C++ practices and the project's C++ standard requirements.

References

The repository style guide states that C++14 is the minimum supported C++ standard version. Using C++17 here is an appropriate upgrade. ^(link)

gemini-code-assist · 2026-01-31T01:28:27Z

ci/gha/builds/vcpkg-overlays/opentelemetry-cpp/portfile.cmake

    WITH_USER_EVENTS
-    BUILD_TRACEPOINTS)
+    BUILD_TRACEPOINTS
+    gRPC_CPP_PLUGIN_EXECUTABLE)


Adding gRPC_CPP_PLUGIN_EXECUTABLE to MAYBE_UNUSED_VARIABLES is a good practice to prevent CMake warnings about unused variables, which can help keep the build output clean and focused on actual issues.

codecov · 2026-01-31T01:50:23Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.86%. Comparing base (e790ce9) to head (ac296b3).

Additional details and impacted files

@@                  Coverage Diff                   @@
##           prepare-for-v3.0.0   #15924      +/-   ##
======================================================
+ Coverage               92.85%   92.86%   +0.01%     
======================================================
  Files                    2343     2343              
  Lines                  216258   216258              
======================================================
+ Hits                   200804   200831      +27     
+ Misses                  15454    15427      -27

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

scotthart added 9 commits January 30, 2026 18:45

gha config

9952159

ci script updates

3f83e44

NOMINMAX on command line

137a960

ggive NOMINMAX a value

b2e8990

add_definitions NOMINMAX

61e7862

if win32 at top level

5c7abaa

build everything

088f9eb

add skipped libs back in

ac6164f

add overlay port to kokoro

7f8e128

scotthart temporarily deployed to internal January 31, 2026 01:25 — with GitHub Actions Inactive

gemini-code-assist bot reviewed Jan 31, 2026

View reviewed changes

vcpkg version regex is bad, don't use it

7243646

scotthart temporarily deployed to internal January 31, 2026 02:21 — with GitHub Actions Inactive

move ports env def

1e13e4f

scotthart temporarily deployed to internal January 31, 2026 14:41 — with GitHub Actions Inactive

adjust overlay path in ps1

726fa5c

scotthart temporarily deployed to internal January 31, 2026 17:27 — with GitHub Actions Inactive

macos cmake

ac296b3

scotthart temporarily deployed to internal February 2, 2026 17:25 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ci gha v3 windows3#15924

Ci gha v3 windows3#15924
scotthart wants to merge 13 commits intoprepare-for-v3.0.0from
ci-gha-v3-windows3

scotthart commented Jan 31, 2026 •

edited

Loading

Uh oh!

gemini-code-assist bot commented Jan 31, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

gemini-code-assist bot Jan 31, 2026

Uh oh!

gemini-code-assist bot Jan 31, 2026

Uh oh!

gemini-code-assist bot Jan 31, 2026

Uh oh!

gemini-code-assist bot Jan 31, 2026

Uh oh!

gemini-code-assist bot Jan 31, 2026

Uh oh!

codecov bot commented Jan 31, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

scotthart commented Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot commented Jan 31, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jan 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

scotthart commented Jan 31, 2026 •

edited

Loading

codecov bot commented Jan 31, 2026 •

edited

Loading