feat(gkerecommender): generate library by scotthart · Pull Request #15935 · googleapis/google-cloud-cpp

scotthart · 2026-02-05T17:34:44Z

This change is

gemini-code-assist · 2026-02-05T17:35:29Z

Summary of Changes

Hello @scotthart, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces the new C++ client library for the GKE Recommender API. This enables developers to programmatically interact with the GKE Recommender service, fetching models, model servers, profiles, and generating optimized manifests directly from their C++ applications. The changes include the generated client code, build system integrations, and user-facing documentation to facilitate adoption.

Highlights

New GKE Recommender C++ Client Library: A new C++ client library for the GKE Recommender API has been generated and added to the repository, enabling programmatic interaction with the service.
Documentation Updates: The CHANGELOG.md and main README.md files have been updated to announce the new GKE Recommender library and provide quickstart and reference links.
Build System Integration: The new library has been seamlessly integrated into the project's CMake and Bazel build systems, including updates to GoogleCloudCppFeatures.cmake and libraries.bzl.
Comprehensive Quickstart and Examples: Detailed quickstart guides, examples, and extensive Doxygen documentation pages have been added to facilitate easy adoption and usage of the new GKE Recommender client library.

Changelog

CHANGELOG.md
- Added "GKE Recommender" to the list of new GA libraries for v2.47.0.
README.md
- Added a new entry for "GKE Recommender API" with quickstart and reference links.
ci/etc/expected_install_directories
- Added expected install directories for gkerecommender includes and mocks.
cmake/GoogleCloudCppFeatures.cmake
- Added "gkerecommender" to the list of GA libraries.
external/googleapis/protodeps/gkerecommender.deps
- Added protobuf dependencies for the gkerecommender service.
external/googleapis/protolists/gkerecommender.list
- Added the gkerecommender.proto file to the list of protobufs.
external/googleapis/update_libraries.sh
- Added gkerecommender to the LIBRARIES array for script updates.
generator/generator_config.textproto
- Added a new service configuration block for GKE Recommender, specifying its proto path, product path, initial copyright year, and retryable status codes.
google/cloud/gkerecommender/BUILD.bazel
- Added a new Bazel build file for the GKE Recommender library.
google/cloud/gkerecommender/CMakeLists.txt
- Added a new CMake build file for the GKE Recommender library, including quickstart executable and test.
google/cloud/gkerecommender/README.md
- Added a new README file detailing the GKE Recommender API C++ Client Library, quickstart instructions, and more information.
google/cloud/gkerecommender/doc/environment-variables.dox
- Added Doxygen documentation for environment variables related to the GKE Recommender library.
google/cloud/gkerecommender/doc/main.dox
- Added main Doxygen documentation for the GKE Recommender API C++ Client Library.
google/cloud/gkerecommender/doc/options.dox
- Added Doxygen documentation for configuration options specific to the GKE Recommender library.
google/cloud/gkerecommender/doc/override-authentication.dox
- Added Doxygen documentation on how to override authentication credentials for the GKE Recommender library.
google/cloud/gkerecommender/doc/override-endpoint.dox
- Added Doxygen documentation on how to override the default endpoint for the GKE Recommender library.
google/cloud/gkerecommender/doc/override-retry-policies.dox
- Added Doxygen documentation on how to override retry, backoff, and idempotency policies for the GKE Recommender library.
google/cloud/gkerecommender/doc/override-universe-domain.dox
- Added Doxygen documentation on how to override the default universe domain for the GKE Recommender library.
google/cloud/gkerecommender/quickstart/.bazelrc
- Added Bazel configuration for the quickstart example.
google/cloud/gkerecommender/quickstart/BUILD.bazel
- Added Bazel build file for the quickstart example.
google/cloud/gkerecommender/quickstart/CMakeLists.txt
- Added CMake build file for the quickstart example.
google/cloud/gkerecommender/quickstart/Makefile
- Added Makefile for the quickstart example.
google/cloud/gkerecommender/quickstart/README.md
- Added README for the quickstart example, detailing usage with Bazel and CMake.
google/cloud/gkerecommender/quickstart/WORKSPACE.bazel
- Added Bazel WORKSPACE file for the quickstart example.
google/cloud/gkerecommender/quickstart/quickstart.cc
- Added the quickstart C++ source file.
google/cloud/gkerecommender/v1/.repo-metadata.json
- Added repository metadata for the GKE Recommender v1 API.
google/cloud/gkerecommender/v1/gke_inference_quickstart_client.cc
- Added the generated C++ client implementation.
google/cloud/gkerecommender/v1/gke_inference_quickstart_client.h
- Added the generated C++ client header.
google/cloud/gkerecommender/v1/gke_inference_quickstart_connection.cc
- Added the generated C++ connection implementation.
google/cloud/gkerecommender/v1/gke_inference_quickstart_connection.h
- Added the generated C++ connection header.
google/cloud/gkerecommender/v1/gke_inference_quickstart_connection_idempotency_policy.cc
- Added the generated C++ idempotency policy implementation.
google/cloud/gkerecommender/v1/gke_inference_quickstart_connection_idempotency_policy.h
- Added the generated C++ idempotency policy header.
google/cloud/gkerecommender/v1/gke_inference_quickstart_options.h
- Added the generated C++ options header.
google/cloud/gkerecommender/v1/internal/gke_inference_quickstart_auth_decorator.cc
- Added the generated C++ authentication decorator implementation.
google/cloud/gkerecommender/v1/internal/gke_inference_quickstart_auth_decorator.h
- Added the generated C++ authentication decorator header.
google/cloud/gkerecommender/v1/internal/gke_inference_quickstart_connection_impl.cc
- Added the generated C++ connection implementation details.
google/cloud/gkerecommender/v1/internal/gke_inference_quickstart_connection_impl.h
- Added the generated C++ connection implementation header.
google/cloud/gkerecommender/v1/internal/gke_inference_quickstart_logging_decorator.cc
- Added the generated C++ logging decorator implementation.
google/cloud/gkerecommender/v1/internal/gke_inference_quickstart_logging_decorator.h
- Added the generated C++ logging decorator header.
google/cloud/gkerecommender/v1/internal/gke_inference_quickstart_metadata_decorator.cc
- Added the generated C++ metadata decorator implementation.
google/cloud/gkerecommender/v1/internal/gke_inference_quickstart_metadata_decorator.h
- Added the generated C++ metadata decorator header.
google/cloud/gkerecommender/v1/internal/gke_inference_quickstart_option_defaults.cc
- Added the generated C++ option defaults implementation.
google/cloud/gkerecommender/v1/internal/gke_inference_quickstart_option_defaults.h
- Added the generated C++ option defaults header.
google/cloud/gkerecommender/v1/internal/gke_inference_quickstart_retry_traits.h
- Added the generated C++ retry traits header.
google/cloud/gkerecommender/v1/internal/gke_inference_quickstart_sources.cc
- Added the generated C++ sources file.
google/cloud/gkerecommender/v1/internal/gke_inference_quickstart_stub.cc
- Added the generated C++ stub implementation.
google/cloud/gkerecommender/v1/internal/gke_inference_quickstart_stub.h
- Added the generated C++ stub header.
google/cloud/gkerecommender/v1/internal/gke_inference_quickstart_stub_factory.cc
- Added the generated C++ stub factory implementation.
google/cloud/gkerecommender/v1/internal/gke_inference_quickstart_stub_factory.h
- Added the generated C++ stub factory header.
google/cloud/gkerecommender/v1/internal/gke_inference_quickstart_tracing_connection.cc
- Added the generated C++ tracing connection implementation.
google/cloud/gkerecommender/v1/internal/gke_inference_quickstart_tracing_connection.h
- Added the generated C++ tracing connection header.
google/cloud/gkerecommender/v1/internal/gke_inference_quickstart_tracing_stub.cc
- Added the generated C++ tracing stub implementation.
google/cloud/gkerecommender/v1/internal/gke_inference_quickstart_tracing_stub.h
- Added the generated C++ tracing stub header.
google/cloud/gkerecommender/v1/mocks/mock_gke_inference_quickstart_connection.h
- Added the generated C++ mock connection header.
google/cloud/gkerecommender/v1/samples/gke_inference_quickstart_client_samples.cc
- Added the generated C++ client samples.
libraries.bzl
- Added "gkerecommender" to the list of GA libraries.

Activity

The GKE Recommender C++ client library was generated and added to the repository.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces the new gkerecommender C++ client library. The changes, which are mostly generated, correctly integrate the new library into the project's build and documentation systems. I have a few suggestions for improvement: one to remove an unused header in the quickstart example for better maintainability, and two to correct the idempotency settings for a couple of API methods to ensure proper retry behavior.

google/cloud/gkerecommender/v1/gke_inference_quickstart_connection_idempotency_policy.cc

google/cloud/gkerecommender/quickstart/quickstart.cc

codecov · 2026-02-05T17:59:56Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.96%. Comparing base (6b12774) to head (4db80e0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #15935   +/-   ##
=======================================
  Coverage   92.96%   92.96%           
=======================================
  Files        2460     2460           
  Lines      228901   228901           
=======================================
+ Hits       212790   212805   +15     
+ Misses      16111    16096   -15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

diegomarquezp

@diegomarquezp reviewed all commit messages.
Reviewable status: 0 of 57 files reviewed, all discussions resolved.

scotthart added 4 commits February 5, 2026 11:18

feat(gkerecommender): generate library

44e74be

Run generators and format their outputs

0579819

Add API baseline

51be46b

Manually update READMEs, quickstart, and top-level stuff

76e0230

scotthart requested a review from a team as a code owner February 5, 2026 17:34

scotthart temporarily deployed to false February 5, 2026 17:34 — with GitHub Actions Inactive

gemini-code-assist bot reviewed Feb 5, 2026

View reviewed changes

remove unused include

e72570a

scotthart temporarily deployed to false February 5, 2026 18:19 — with GitHub Actions Inactive

scotthart enabled auto-merge (squash) February 5, 2026 20:46

Merge branch 'main' into feat-gkerecommender-generate-library

4db80e0

scotthart temporarily deployed to false February 5, 2026 22:07 — with GitHub Actions Inactive

diegomarquezp reviewed Feb 6, 2026

View reviewed changes

diegomarquezp approved these changes Feb 6, 2026

View reviewed changes

scotthart merged commit 5bb66b7 into googleapis:main Feb 6, 2026
64 of 65 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(gkerecommender): generate library#15935

feat(gkerecommender): generate library#15935
scotthart merged 6 commits intogoogleapis:mainfrom
scotthart:feat-gkerecommender-generate-library

scotthart commented Feb 5, 2026 •

edited

Loading

Uh oh!

gemini-code-assist bot commented Feb 5, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Feb 5, 2026 •

edited

Loading

Uh oh!

diegomarquezp left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

scotthart commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot commented Feb 5, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

diegomarquezp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

scotthart commented Feb 5, 2026 •

edited

Loading

codecov bot commented Feb 5, 2026 •

edited

Loading