chore: update library generation for use with bzlmod#16006
chore: update library generation for use with bzlmod#16006scotthart merged 3 commits intogoogleapis:mainfrom
Conversation
Summary of ChangesHello @scotthart, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the project's Bazel configuration to improve compatibility with Bzlmod and refines the library generation process. It includes an update to the Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the library generation process to be compatible with bzlmod. The changes include updating dependency versions, modifying Bazel configuration files, and adjusting build scripts and documentation to use bzlmod-style paths and commands. The changes look good overall, but I have one suggestion to improve the documentation to be more consistent with bzlmod practices.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16006 +/- ##
=======================================
Coverage 92.63% 92.64%
=======================================
Files 2334 2333 -1
Lines 214633 214631 -2
=======================================
+ Hits 198834 198846 +12
+ Misses 15799 15785 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9524d3f to
062520e
Compare
diegomarquezp
left a comment
There was a problem hiding this comment.
@diegomarquezp reviewed 15 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on scotthart).
This change is