Skip to content

chore: update library generation for use with bzlmod#16006

Merged
scotthart merged 3 commits intogoogleapis:mainfrom
scotthart:bzlmod_library_generation
Feb 25, 2026
Merged

chore: update library generation for use with bzlmod#16006
scotthart merged 3 commits intogoogleapis:mainfrom
scotthart:bzlmod_library_generation

Conversation

@scotthart
Copy link
Copy Markdown
Member

@scotthart scotthart commented Feb 24, 2026

This change is Reviewable

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @scotthart, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the project's Bazel configuration to improve compatibility with Bzlmod and refines the library generation process. It includes an update to the yaml-cpp dependency and simplifies how external protobuf and googleapis paths are resolved, aiming for more robust and consistent builds across different Bazel modes. The changes also ensure the contributor guide reflects these updated configurations.

Highlights

  • Dependency Update: Updated the yaml-cpp dependency to version 0.9.0 across Bazel configuration files.
  • Library Generation Script Refinement: Streamlined the resolution of external protobuf and googleapis paths in the generate-libraries.sh script by using direct paths instead of dynamic find commands.
  • Documentation Update: Adjusted the contributor guide for adding generated libraries to include necessary Bazel workspace mode flags and updated external dependency paths for the generator script.
Changelog
  • MODULE.bazel
    • Updated yaml-cpp version from 0.8.0 to 0.9.0.
  • bazel/development0.bzl
    • Updated the http_archive URL for com_github_jbeder_yaml_cpp to yaml-cpp-0.9.0.tar.gz.
    • Updated the sha256 hash for the yaml-cpp archive.
    • Updated the strip_prefix for the yaml-cpp archive.
  • ci/cloudbuild/builds/generate-libraries.sh
    • Replaced dynamic find commands with direct path assignments for protobuf_proto_path and googleapis_proto_path.
  • doc/contributor/howto-guide-adding-generated-libraries.md
    • Added --enable_workspace --noenable_bzlmod --incompatible_disallow_empty_glob=no flags to the bazelisk query command example.
    • Updated protobuf_proto_path and googleapis_proto_path arguments in the bazelisk run command example to use protobuf+/src and googleapis+.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the library generation process to be compatible with bzlmod. The changes include updating dependency versions, modifying Bazel configuration files, and adjusting build scripts and documentation to use bzlmod-style paths and commands. The changes look good overall, but I have one suggestion to improve the documentation to be more consistent with bzlmod practices.

Comment thread doc/contributor/howto-guide-adding-generated-libraries.md
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.64%. Comparing base (3855556) to head (062520e).
⚠️ Report is 57 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16006   +/-   ##
=======================================
  Coverage   92.63%   92.64%           
=======================================
  Files        2334     2333    -1     
  Lines      214633   214631    -2     
=======================================
+ Hits       198834   198846   +12     
+ Misses      15799    15785   -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@diegomarquezp diegomarquezp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@diegomarquezp reviewed 15 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on scotthart).

@scotthart scotthart enabled auto-merge (squash) February 25, 2026 01:53
@scotthart scotthart merged commit ec22823 into googleapis:main Feb 25, 2026
58 of 65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants