Skip to content

feat(networksecurity): update library#16122

Merged
scotthart merged 5 commits into
googleapis:mainfrom
scotthart:feat-networksecurity-generate-library
May 27, 2026
Merged

feat(networksecurity): update library#16122
scotthart merged 5 commits into
googleapis:mainfrom
scotthart:feat-networksecurity-generate-library

Conversation

@scotthart
Copy link
Copy Markdown
Member

PiperOrigin-RevId: 919268561

@product-auto-label product-auto-label Bot added the api: networksecurity Issues related to the Network Security API API. label May 27, 2026
@scotthart scotthart marked this pull request as ready for review May 27, 2026 16:24
@scotthart scotthart requested a review from a team as a code owner May 27, 2026 16:24
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several new services to the Network Security API C++ client library, including Address Group, DNS Threat Detector, Firewall Activation, and Intercept. It generates the corresponding client, connection, stub, and decorator classes, and updates the documentation and configuration files. The review feedback highlights critical compilation errors in address_group_client.cc where iterators are incorrectly assigned to a RepeatedPtrField, and a formatting issue in CHANGELOG.md with an empty markdown link placeholder.

Comment thread google/cloud/networksecurity/v1/address_group_client.cc
Comment thread google/cloud/networksecurity/v1/address_group_client.cc
Comment thread google/cloud/networksecurity/v1/address_group_client.cc
Comment thread google/cloud/networksecurity/v1/address_group_client.cc
Comment thread CHANGELOG.md
@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.71%. Comparing base (a393a27) to head (b7297ec).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16122      +/-   ##
==========================================
- Coverage   92.71%   92.71%   -0.01%     
==========================================
  Files        2353     2353              
  Lines      219451   219451              
==========================================
- Hits       203474   203470       -4     
- Misses      15977    15981       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scotthart scotthart enabled auto-merge (squash) May 27, 2026 17:10
@scotthart scotthart merged commit 00f057d into googleapis:main May 27, 2026
56 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: networksecurity Issues related to the Network Security API API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants