Skip to content

impl(oauth2): omit RAB header when locations unbounded#16136

Merged
scotthart merged 1 commit into
googleapis:mainfrom
scotthart:oauth2_rab_unbounded_omit
Jun 4, 2026
Merged

impl(oauth2): omit RAB header when locations unbounded#16136
scotthart merged 1 commit into
googleapis:mainfrom
scotthart:oauth2_rab_unbounded_omit

Conversation

@scotthart
Copy link
Copy Markdown
Member

If the returned encoded_locations has a value of 0x0, then omit the x-allowed-locations header altogether.

@scotthart scotthart requested a review from a team as a code owner June 4, 2026 15:46
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the IsUnbounded helper method to AllowedLocationsResponse to check if the encoded locations are set to '0x0'. It updates RegionalAccessBoundaryTokenManager to omit the x-allowed-locations header when the locations are unbounded, and adds a corresponding unit test to verify this behavior. I have no feedback to provide as the changes are well-implemented and include appropriate test coverage.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.70%. Comparing base (458cbf4) to head (2d2119f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16136      +/-   ##
==========================================
- Coverage   92.72%   92.70%   -0.02%     
==========================================
  Files        2356     2356              
  Lines      220497   220517      +20     
==========================================
- Hits       204448   204441       -7     
- Misses      16049    16076      +27     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scotthart scotthart enabled auto-merge (squash) June 4, 2026 18:34
@scotthart scotthart merged commit 8d79f18 into googleapis:main Jun 4, 2026
56 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants