Do not throw exceptions in WriteObject().#2400
Merged
coryan merged 1 commit intogoogleapis:masterfrom Apr 4, 2019
Merged
Conversation
We were still throwing an exception in WriteObject() for some types of errors. This fixes that problem and adds integration tests to verify we do not throw exceptions in other media operations (downloads, uploads, etc.)
googlebot
added
the
cla: yes
devjgm
approved these changes
Apr 4, 2019
Codecov Report
@@ Coverage Diff @@
## master #2400 +/- ##
==========================================
+ Coverage 92.71% 92.72% +<.01%
==========================================
Files 309 309
Lines 19305 19314 +9
==========================================
+ Hits 17899 17908 +9
Misses 1406 1406
Continue to review full report at Codecov.
|
devbww
approved these changes
Apr 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were still throwing an exception in WriteObject() for some types of
errors. This fixes that problem and adds integration tests to verify we
do not throw exceptions in other media operations (downloads, uploads,
etc.)
This fixes #2374.
This change is