testing: Fix build on windows 2019#2932
testing: Fix build on windows 2019#2932tmatsuo merged 7 commits intogoogleapis:masterfrom tmatsuo:windows-2019
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2932 +/- ##
==========================================
- Coverage 90.58% 90.58% -0.01%
==========================================
Files 297 297
Lines 20153 20155 +2
==========================================
+ Hits 18256 18257 +1
- Misses 1897 1898 +1
Continue to review full report at Codecov.
|
|
Using full path didn't work on windows 2019. Closing for now. |
|
It works when setting Path env var in the powershell script. Reopening |
coryan
left a comment
There was a problem hiding this comment.
Do we want to keep builds on windows 2016? If not, I'll eventually remove files for windows 2016 builds.
No. We may want to have multiple builds with different MSVC versions, but the base OS is not that relevant I think.
Reviewed 2 of 3 files at r1, 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
I need to use the full path of cmd in order to run 7-zip in both images. Probably because some difference between cygwin on windows 2016 image and msys2 on windows 2019 image.
Do we want to keep builds on windows 2016? If not, I'll eventually remove files for windows 2016 builds.
This change is