Skip to content

testing: Fix build on windows 2019#2932

Merged
tmatsuo merged 7 commits intogoogleapis:masterfrom
tmatsuo:windows-2019
Aug 4, 2019
Merged

testing: Fix build on windows 2019#2932
tmatsuo merged 7 commits intogoogleapis:masterfrom
tmatsuo:windows-2019

Conversation

@tmatsuo
Copy link
Copy Markdown
Contributor

@tmatsuo tmatsuo commented Aug 3, 2019

I need to use the full path of cmd in order to run 7-zip in both images. Probably because some difference between cygwin on windows 2016 image and msys2 on windows 2019 image.

Do we want to keep builds on windows 2016? If not, I'll eventually remove files for windows 2016 builds.


This change is Reviewable

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 3, 2019
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 3, 2019

Codecov Report

Merging #2932 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2932      +/-   ##
==========================================
- Coverage   90.58%   90.58%   -0.01%     
==========================================
  Files         297      297              
  Lines       20153    20155       +2     
==========================================
+ Hits        18256    18257       +1     
- Misses       1897     1898       +1
Impacted Files Coverage Δ
google/cloud/storage/internal/curl_handle.h 65.62% <0%> (-12.5%) ⬇️
google/cloud/storage/well_known_headers.h 77.77% <0%> (-11.12%) ⬇️
google/cloud/storage/internal/generic_request.h 78.37% <0%> (-8.11%) ⬇️
google/cloud/storage/object_stream.h 94.64% <0%> (-1.79%) ⬇️
google/cloud/storage/internal/logging_client.cc 97.76% <0%> (-0.02%) ⬇️
google/cloud/bigtable/row_range.h 100% <0%> (ø) ⬆️
google/cloud/internal/retry_policy.h 100% <0%> (ø) ⬆️
google/cloud/storage/well_known_parameters.h 75.55% <0%> (+4.44%) ⬆️
...oogle/cloud/bigtable/internal/unary_client_utils.h 100% <0%> (+17.85%) ⬆️
google/cloud/storage/oauth2/credentials.h 66.66% <0%> (+33.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6637725...fb79246. Read the comment docs.

@tmatsuo
Copy link
Copy Markdown
Contributor Author

tmatsuo commented Aug 3, 2019

Using full path didn't work on windows 2019. Closing for now.

@tmatsuo tmatsuo closed this Aug 3, 2019
@tmatsuo
Copy link
Copy Markdown
Contributor Author

tmatsuo commented Aug 3, 2019

It works when setting Path env var in the powershell script. Reopening

@tmatsuo tmatsuo reopened this Aug 3, 2019
Copy link
Copy Markdown
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to keep builds on windows 2016? If not, I'll eventually remove files for windows 2016 builds.

No. We may want to have multiple builds with different MSVC versions, but the base OS is not that relevant I think.

:lgtm:

Reviewed 2 of 3 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@tmatsuo tmatsuo merged commit afecdc8 into googleapis:master Aug 4, 2019
@tmatsuo tmatsuo deleted the windows-2019 branch August 4, 2019 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants