Skip to content

feat: updated CHANGELOG for 2020-07 release#4452

Merged
devbww merged 2 commits intogoogleapis:masterfrom
devbww:july-release
Jul 1, 2020
Merged

feat: updated CHANGELOG for 2020-07 release#4452
devbww merged 2 commits intogoogleapis:masterfrom
devbww:july-release

Conversation

@devbww
Copy link
Copy Markdown
Contributor

@devbww devbww commented Jul 1, 2020

This change is Reviewable

@devbww devbww requested a review from a team July 1, 2020 14:52
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 1, 2020
Copy link
Copy Markdown
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @devbww)


CHANGELOG.md, line 9 at r1 (raw file):

### Bigtable

* fix: rotate through backup tests to stay under quota (#4420)

I think CI fixes like this and the #4369 below are uninteresting to our users and we should remove them from the CHANGELOG.


CHANGELOG.md, line 16 at r1 (raw file):

### Storage

* fix(storage): accept more than one matching log line (#4445)

This, and #4403, #4390 are uninteresting to our users.


CHANGELOG.md, line 34 at r1 (raw file):

* fix(spanner): examples on how to delete data (#4401)
* feat: use `SELECT 1` to refresh sessions (#4377)
* ci(spanner): auto drop databases for realsies (#4371)

Ditto regarding ci() fixes.

Copy link
Copy Markdown
Contributor Author

@devbww devbww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @coryan)


CHANGELOG.md, line 9 at r1 (raw file):

Previously, coryan (Carlos O'Ryan) wrote…

I think CI fixes like this and the #4369 below are uninteresting to our users and we should remove them from the CHANGELOG.

Done.


CHANGELOG.md, line 16 at r1 (raw file):

Previously, coryan (Carlos O'Ryan) wrote…

This, and #4403, #4390 are uninteresting to our users.

Done.


CHANGELOG.md, line 34 at r1 (raw file):

Previously, coryan (Carlos O'Ryan) wrote…

Ditto regarding ci() fixes.

Done.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 1, 2020

Codecov Report

Merging #4452 into master will increase coverage by 0.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4452      +/-   ##
==========================================
+ Coverage   92.43%   92.58%   +0.15%     
==========================================
  Files         869      869              
  Lines       68037    68035       -2     
==========================================
+ Hits        62888    62993     +105     
+ Misses       5149     5042     -107     
Impacted Files Coverage Δ
...le/cloud/spanner/internal/database_admin_logging.h 0.00% <0.00%> (-100.00%) ⬇️
...le/cloud/spanner/internal/instance_admin_logging.h 0.00% <0.00%> (-100.00%) ⬇️
...cloud/spanner/internal/logging_result_set_reader.h 0.00% <0.00%> (-100.00%) ⬇️
...cloud/spanner/internal/partial_result_set_reader.h 0.00% <0.00%> (-100.00%) ⬇️
...torage/internal/logging_resumable_upload_session.h 0.00% <0.00%> (-100.00%) ⬇️
google/cloud/bigtable/internal/bulk_mutator.h 33.33% <0.00%> (-66.67%) ⬇️
...gle/cloud/storage/internal/curl_download_request.h 16.66% <0.00%> (-66.67%) ⬇️
google/cloud/spanner/bytes.h 51.72% <0.00%> (-48.28%) ⬇️
google/cloud/spanner/testing/mock_spanner_stub.h 11.76% <0.00%> (-47.06%) ⬇️
google/cloud/bigtable/internal/async_poll_op.h 35.13% <0.00%> (-45.95%) ⬇️
... and 80 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fbe4bf...f58a074. Read the comment docs.

Copy link
Copy Markdown
Contributor

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@mr-salty
Copy link
Copy Markdown
Contributor

mr-salty commented Jul 1, 2020


CHANGELOG.md, line 9 at r1 (raw file):

Previously, devbww (Bradley White) wrote…

Done.

for future reference, should these have been tagged test rather than fix? (my vote is yes)

@devbww devbww merged commit 8a0d62b into googleapis:master Jul 1, 2020
@devbww devbww deleted the july-release branch July 1, 2020 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants