fix(gcb): ldconfig /usr/local/lib after installing stuff #6248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: googleapis#6247 `ldconfig` doesn't always add stuff in `/usr/local/lib` directories, so in Dockerfiles when we install a bunch of stuff that might land in `/usr/local`, we should be sure to run ldconfig on /usr/local before we attempt to use those things (or expect pkg-config to find them).
google-cla
bot
added
the
cla: yes
coryan
approved these changes
Apr 14, 2021
Codecov Report
@@ Coverage Diff @@
## master #6248 +/- ##
=======================================
Coverage 95.67% 95.67%
=======================================
Files 1177 1177
Lines 105228 105228
=======================================
Hits 100682 100682
Misses 4546 4546 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6247
ldconfigdoesn't always add stuff in/usr/local/libdirectories, soin Dockerfiles when we install a bunch of stuff that might land in
/usr/local, we should be sure to run ldconfig on /usr/local before weattempt to use those things (or expect pkg-config to find them).
This change is