ci(gcb): add shared library build #6257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixed an issue where the pubsub protos were missing a needed dep. This PR refactors the logic to run the CMake and Makefile quickstart builds into a library, because it turns out that this is a useful way to verify that our installed artifacts work, and we end up calling this from a few places.
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #6257 +/- ##
=======================================
Coverage 95.68% 95.68%
=======================================
Files 1178 1178
Lines 105216 105216
=======================================
Hits 100671 100671
Misses 4545 4545 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixed an issue where the pubsub protos were missing a needed dep.
This PR refactors the logic to run the CMake and Makefile quickstart
builds into a library, because it turns out that this is a useful way to
verify that our installed artifacts work, and we end up calling this
from a few places.
This change is