Skip to content

doc: update CHANGELOG for v1.34.0 release#7675

Merged
coryan merged 3 commits into
googleapis:mainfrom
coryan:doc-update-changelog-v1.34.0
Dec 1, 2021
Merged

doc: update CHANGELOG for v1.34.0 release#7675
coryan merged 3 commits into
googleapis:mainfrom
coryan:doc-update-changelog-v1.34.0

Conversation

@coryan
Copy link
Copy Markdown
Contributor

@coryan coryan commented Nov 30, 2021 •
edited
Loading

This change is Reviewable

@coryan coryan requested a review from a team November 30, 2021 22:32
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 30, 2021
@google-cloud-cpp-bot
Copy link
Copy Markdown
Contributor

google-cloud-cpp-bot commented Nov 30, 2021

Google Cloud Build Logs
For commit: bcff301f5186581169eb668eca3a5d634680533e

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 30, 2021 •
edited
Loading

Codecov Report

Merging #7675 (2e3a08c) into main (b92933b) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7675      +/-   ##
==========================================
- Coverage   95.28%   95.28%   -0.01%     
==========================================
  Files        1254     1254              
  Lines      113312   113312              
==========================================
- Hits       107972   107969       -3     
- Misses       5340     5343       +3
Impacted Files Coverage Δ
google/cloud/bigtable/async_read_stream_test.cc 97.32% <0.00%> (-0.67%) ⬇️
...le/cloud/storage/internal/curl_download_request.cc 89.25% <0.00%> (-0.38%) ⬇️
...ud/spanner/integration_tests/client_stress_test.cc 86.18% <0.00%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b92933b...2e3a08c. Read the comment docs.

dbolduc
dbolduc reviewed Nov 30, 2021
View reviewed changes
Comment thread CHANGELOG.md Outdated

[Cloud Tasks]: https://github.com/googleapis/google-cloud-cpp/blob/main/google/cloud/tasks/README.md
[Secret Manager]: https://github.com/googleapis/google-cloud-cpp/blob/main/google/cloud/secretmanager/README.md
[Pub/Sub Lite]: https://github.com/googleapis/google-cloud-cpp/blob/main/google/cloud/secretmanager/README.md
Copy link
Copy Markdown
Member

@dbolduc dbolduc Nov 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/secretmanager/pubsublite/

@google-cloud-cpp-bot
Copy link
Copy Markdown
Contributor

google-cloud-cpp-bot commented Nov 30, 2021

Google Cloud Build Logs
For commit: 81500a9c0a3f53d27bf8024f2081fed5261ed116

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

devbww
devbww reviewed Dec 1, 2021
View reviewed changes
Comment thread CHANGELOG.md Outdated

* feat(generator): document details about `*Client` ([#7673](https://github.com/googleapis/google-cloud-cpp/pull/7673))
* feat(generator): link each method input and output types ([#7665](https://github.com/googleapis/google-cloud-cpp/pull/7665))
* feat(common): add tracing for the LRO polling loop ([#7615](https://github.com/googleapis/google-cloud-cpp/pull/7615))
Copy link
Copy Markdown
Contributor

@devbww devbww Dec 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already appears in "Common Libraries"?

Copy link
Copy Markdown
Contributor Author

@coryan coryan Dec 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed, thanks.

@google-cloud-cpp-bot
Copy link
Copy Markdown
Contributor

google-cloud-cpp-bot commented Dec 1, 2021

Google Cloud Build Logs
For commit: 2e3a08c43aa76c87e16663005f1098989e3df277

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

devbww
devbww approved these changes Dec 1, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@devbww devbww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what its worth, LGTM.

@coryan coryan merged commit 31d387e into googleapis:main Dec 1, 2021
@coryan coryan deleted the doc-update-changelog-v1.34.0 branch December 1, 2021 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbolduc dbolduc dbolduc left review comments

+1 more reviewer

@devbww devbww devbww approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@coryan @google-cloud-cpp-bot @devbww @dbolduc