chore: update CHANGELOG.md for v1.35 by devjgm · Pull Request #7797 · googleapis/google-cloud-cpp

devjgm · 2022-01-04T15:16:54Z

This change is

google-cloud-cpp-bot · 2022-01-04T15:19:16Z

Google Cloud Build Logs
For commit: 690bed60154c4f9ec972131ddcc0332a9daf00f9

Public Access Build Logs
Cloud Build Console (requires auth)
Kokoro Logs (requires auth)

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

codecov · 2022-01-04T15:24:34Z

Codecov Report

Merging #7797 (67a9c85) into main (b289fad) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #7797      +/-   ##
==========================================
- Coverage   95.16%   95.15%   -0.01%     
==========================================
  Files        1278     1278              
  Lines      115115   115115              
==========================================
- Hits       109546   109540       -6     
- Misses       5569     5575       +6

Impacted Files	Coverage Δ
google/cloud/bigtable/internal/common_client.h	`94.02% <0.00%> (-5.98%)`	⬇️
...integration_tests/schema_admin_integration_test.cc	`98.91% <0.00%> (-1.09%)`	⬇️
google/cloud/pubsub/subscriber_connection_test.cc	`97.18% <0.00%> (-0.71%)`	⬇️
...cloud/pubsub/internal/subscription_session_test.cc	`97.75% <0.00%> (-0.25%)`	⬇️
...ud/spanner/integration_tests/client_stress_test.cc	`86.18% <0.00%> (+0.65%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b289fad...67a9c85. Read the comment docs.

dbolduc · 2022-01-04T15:26:39Z

+
+### [Bigtable](https://github.com/googleapis/google-cloud-cpp/blob/main/google/cloud/bigtable/README.md)
+
+* feat(pubsublite): stream factories for PSL bidi streams ([#7671](https://github.com/googleapis/google-cloud-cpp/pull/7671))


This can be deleted. (Not just because it is a pubsublite change in the bigtable section. The PR was an internal only change)

Also, do we want to add pubsublite to this list now that it has handwritten code?

google-cloud-cpp/release/changes.sh

Lines 75 to 82 in b289fad

sections=(

"BigQuery,google/cloud/bigquery"

"Bigtable,google/cloud/bigtable"

"IAM,google/cloud/iam"

"Pub/Sub,google/cloud/pubsub"

"Spanner,google/cloud/spanner"

"Storage,google/cloud/storage"

)

In the past, we only document changes in libraries once they are GA.

Removed. I can add pubsublite to the changes.sh script if we want. If I added it now it would include:

### [Pub/Sub Lite](https://github.com/googleapis/google-cloud-cpp/blob/main/google/cloud/pubsublite/README.md) * feat(pubsublite): stream factories for PSL bidi streams ([#7671](https://github.com/googleapis/google-cloud-cpp/pull/7671)) * feat(generator): add options support to generated clients ([#7683](https://github.com/googleapis/google-cloud-cpp/pull/7683))

If that's useful to include, I can add it.

coryan · 2022-01-04T15:27:30Z

+
+### [Bigtable](https://github.com/googleapis/google-cloud-cpp/blob/main/google/cloud/bigtable/README.md)
+
+* feat(pubsublite): stream factories for PSL bidi streams ([#7671](https://github.com/googleapis/google-cloud-cpp/pull/7671))


Please remove the pubsublite change, it was just some test refactoring in Bigtable, and a bit confusing to add this in the Bigtable list.

coryan · 2022-01-04T15:28:34Z

+* doc: declare Secret Manager and Task as GA ([#7792](https://github.com/googleapis/google-cloud-cpp/pull/7792))
+* fix: extremely rare race conditions in retry loop ([#7789](https://github.com/googleapis/google-cloud-cpp/pull/7789))
+* feat(common): include the request/response type name in the RPC log ([#7782](https://github.com/googleapis/google-cloud-cpp/pull/7782))
+* feat(GCS+gRPC): implement parser for BucketMetadata components ([#7766](https://github.com/googleapis/google-cloud-cpp/pull/7766))


The changes related to GCS+gRPC seem redundant here?

google-cloud-cpp-bot · 2022-01-04T15:31:50Z

Google Cloud Build Logs
For commit: 33af84210c9d71da3b4d634bdd9a612a8e60befd

Public Access Build Logs
Cloud Build Console (requires auth)
Kokoro Logs (requires auth)

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

google-cloud-cpp-bot · 2022-01-04T15:42:50Z

Google Cloud Build Logs
For commit: 32b755bd4d687b8272f8f4f500f0dbc24340734c

Public Access Build Logs
Cloud Build Console (requires auth)
Kokoro Logs (requires auth)

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

google-cloud-cpp-bot · 2022-01-04T15:48:10Z

Google Cloud Build Logs
For commit: 67a9c85b88463bfcc152e63db072c3922f9453b6

Public Access Build Logs
Cloud Build Console (requires auth)
Kokoro Logs (requires auth)

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

devjgm added 2 commits January 4, 2022 10:12

chore: update CHANGELOG.md for v1.35

bbe6e2a

removed some internal things

690bed6

devjgm requested a review from a team January 4, 2022 15:16

dbolduc reviewed Jan 4, 2022

View reviewed changes

removed pubsublite PR from BT section

33af842

coryan approved these changes Jan 4, 2022

View reviewed changes

dbolduc reviewed Jan 4, 2022

View reviewed changes

Comment thread CHANGELOG.md Outdated

PR comments

32b755b

dbolduc reviewed Jan 4, 2022

View reviewed changes

Comment thread CHANGELOG.md Outdated

Comment thread CHANGELOG.md Outdated

Comment thread CHANGELOG.md Outdated

Comment thread CHANGELOG.md Outdated

Comment thread CHANGELOG.md Outdated

Comment thread CHANGELOG.md Outdated

removed library specific changes from common section

67a9c85

dbolduc approved these changes Jan 4, 2022

View reviewed changes

coryan approved these changes Jan 4, 2022

View reviewed changes

devjgm merged commit eec7062 into googleapis:main Jan 4, 2022

joezqren pushed a commit to joezqren/google-cloud-cpp that referenced this pull request Jan 10, 2022

chore: update CHANGELOG.md for v1.35 (googleapis#7797)

8416da3


		### [Bigtable](https://github.com/googleapis/google-cloud-cpp/blob/main/google/cloud/bigtable/README.md)

		* feat(pubsublite): stream factories for PSL bidi streams ([#7671](https://github.com/googleapis/google-cloud-cpp/pull/7671))

	sections=(
	"BigQuery,google/cloud/bigquery"
	"Bigtable,google/cloud/bigtable"
	"IAM,google/cloud/iam"
	"Pub/Sub,google/cloud/pubsub"
	"Spanner,google/cloud/spanner"
	"Storage,google/cloud/storage"
	)

Conversation

devjgm commented Jan 4, 2022 • edited by coryan Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

google-cloud-cpp-bot commented Jan 4, 2022

Uh oh!

codecov Bot commented Jan 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dbolduc Jan 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coryan Jan 4, 2022

Choose a reason for hiding this comment

Uh oh!

devjgm Jan 4, 2022

Choose a reason for hiding this comment

Uh oh!

coryan Jan 4, 2022

Choose a reason for hiding this comment

Uh oh!

coryan Jan 4, 2022

Choose a reason for hiding this comment

Uh oh!

google-cloud-cpp-bot commented Jan 4, 2022

Uh oh!

Uh oh!

google-cloud-cpp-bot commented Jan 4, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

google-cloud-cpp-bot commented Jan 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

devjgm commented Jan 4, 2022 •

edited by coryan

Loading

codecov Bot commented Jan 4, 2022 •

edited

Loading

dbolduc Jan 4, 2022 •

edited

Loading