cleanup(bigtable): store project id in InstanceAdmin #8051
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the work for #7534
We need to store the project id ourselves, so we can eventually drop our dependence on the legacy
client_.The full change (short of a CHANGELOG entry) is here: https://github.com/dbolduc/google-cloud-cpp/compare/bigtable-convert-instance-admin
The diff is 4500 lines. I am trying to break it up into something more palatable. My plan is to break it into the following PRs:
Options.InstanceAdminin terms of the generated Connection. Rewrite the unit tests. Update the CHANGELOG. (This will be a tedious PR).InstanceAdminClientclass. Delete unused classes and their tests.This change is