docs(iam): added comments on private_key_data#8204
Conversation
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
| if (!response) throw std::runtime_error(response.status().message()); | ||
| // The private_key_data field in the response contains the | ||
| // service account key in JSON format. | ||
| // TODO(Developer): Save the key to a secure location. |
There was a problem hiding this comment.
We do not leave TODO(Developer) marks in our examples. Also note that these examples are executable as-is, the parameters are received from the command-line, so the developer may not see this comment. I think instead we should do something like:
std::cout << "ServiceAccountKey successfully created: "
<< response->DebugString() << "\n";
<< "Please save the key in a secure location, as they cannot be downloaded later\n";There was a problem hiding this comment.
Thank you for the insight. Modified the comment.
Codecov Report
@@ Coverage Diff @@
## main #8204 +/- ##
==========================================
- Coverage 94.63% 94.62% -0.01%
==========================================
Files 1323 1323
Lines 118583 118583
==========================================
- Hits 112218 112213 -5
- Misses 6365 6370 +5
Continue to review full report at Codecov.
|
|
FYI, the robots do not like the extra space at the end of one of your comments. Public versions of the logs are available from #8204 (comment) |
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
|
These instructions may help you speed up the edit -> test -> edit cycle: Please refrain from starting more builds until at least |
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
|
Thanks for the PR! I will fix the build problem and merge this later today. We are in the middle of a release so please don't merge quite yet. |
This change is