Skip to content

fix: correct uses of target_compatible_with#8257

Merged
coryan merged 4 commits into
googleapis:mainfrom
coryan:fix-bazel-and-target-compatible-with
Feb 5, 2022
Merged

fix: correct uses of target_compatible_with#8257
coryan merged 4 commits into
googleapis:mainfrom
coryan:fix-bazel-and-target-compatible-with

Conversation

@coryan
Copy link
Copy Markdown
Contributor

@coryan coryan commented Feb 5, 2022

Perhaps misleadingly, the list of constraints provided to
target_compatible_with form a conjunction: all these constraints must
be satisfied for the rule to be compatible:

A list of constraint_values that must be present

https://docs.bazel.build/versions/main/be/common-definitions.html#common.target_compatible_with

What wanted to do in all cases was to exclude one platform, and
fortunately Bazel provides @platforms//:incompatible for that purpose.

Part of the work for #7936


This change is Reviewable

Perhaps misleadingly, the list of constraints provided to
`target_compatible_with` form a conjunction: all these constraints must
be satisfied for the rule to be compatible:

> A list of constraint_values that **must** be present

https://docs.bazel.build/versions/main/be/common-definitions.html#common.target_compatible_with

What wanted to do in all cases was to exclude one platform, and
fortunately Bazel provides `@platforms//:incompatible` for that purpose.
@google-cloud-cpp-bot
Copy link
Copy Markdown
Contributor

Google Cloud Build Logs
For commit: 60805ba0ec117651c7cb5160f704962cbea93476

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

Copy link
Copy Markdown
Contributor

@devjgm devjgm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Thanks for fixing.

@google-cloud-cpp-bot
Copy link
Copy Markdown
Contributor

Google Cloud Build Logs
For commit: 63eebd778d46ebc7c2cac788142f392396bff3f4

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 5, 2022

Codecov Report

Merging #8257 (2daac2a) into main (6d7d6c3) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8257      +/-   ##
==========================================
- Coverage   94.94%   94.94%   -0.01%     
==========================================
  Files        1331     1331              
  Lines      119222   119222              
==========================================
- Hits       113195   113194       -1     
- Misses       6027     6028       +1     
Impacted Files Coverage Δ
google/cloud/bigtable/internal/common_client.h 94.02% <0.00%> (-5.98%) ⬇️
google/cloud/internal/async_rpc_details.h 94.44% <0.00%> (-5.56%) ⬇️
google/cloud/bigtable/internal/common_client.cc 95.71% <0.00%> (-1.43%) ⬇️
...integration_tests/schema_admin_integration_test.cc 98.88% <0.00%> (-1.12%) ⬇️
google/cloud/pubsub/samples/samples.cc 92.02% <0.00%> (-0.08%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 98.00% <0.00%> (+0.24%) ⬆️
...le/cloud/internal/default_completion_queue_impl.cc 97.72% <0.00%> (+0.56%) ⬆️
google/cloud/storage/well_known_parameters.h 98.00% <0.00%> (+1.00%) ⬆️
...le/cloud/storage/internal/curl_download_request.cc 90.10% <0.00%> (+1.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d7d6c3...2daac2a. Read the comment docs.

@coryan coryan marked this pull request as ready for review February 5, 2022 18:19
@coryan coryan requested a review from a team February 5, 2022 18:19
@coryan coryan enabled auto-merge (squash) February 5, 2022 18:19
@google-cloud-cpp-bot
Copy link
Copy Markdown
Contributor

Google Cloud Build Logs
For commit: ad142018ff61b35400e2cfa2c707ad2472528152

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@google-cloud-cpp-bot
Copy link
Copy Markdown
Contributor

Google Cloud Build Logs
For commit: 2daac2a0721e6bf4c07f059644092a1fa84988ef

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan merged commit 5cc1297 into googleapis:main Feb 5, 2022
@coryan coryan deleted the fix-bazel-and-target-compatible-with branch February 5, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants