fix: correct uses of target_compatible_with#8257
Conversation
Perhaps misleadingly, the list of constraints provided to `target_compatible_with` form a conjunction: all these constraints must be satisfied for the rule to be compatible: > A list of constraint_values that **must** be present https://docs.bazel.build/versions/main/be/common-definitions.html#common.target_compatible_with What wanted to do in all cases was to exclude one platform, and fortunately Bazel provides `@platforms//:incompatible` for that purpose.
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #8257 +/- ##
==========================================
- Coverage 94.94% 94.94% -0.01%
==========================================
Files 1331 1331
Lines 119222 119222
==========================================
- Hits 113195 113194 -1
- Misses 6027 6028 +1
Continue to review full report at Codecov.
|
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Perhaps misleadingly, the list of constraints provided to
target_compatible_withform a conjunction: all these constraints mustbe satisfied for the rule to be compatible:
https://docs.bazel.build/versions/main/be/common-definitions.html#common.target_compatible_with
What wanted to do in all cases was to exclude one platform, and
fortunately Bazel provides
@platforms//:incompatiblefor that purpose.Part of the work for #7936
This change is