feat(generator): support parameters named "options"#8283
Merged
coryan merged 5 commits intoFeb 7, 2022
Merged
Conversation
Contributor
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #8283 +/- ##
=======================================
Coverage 94.94% 94.94%
=======================================
Files 1337 1337
Lines 119336 119336
=======================================
Hits 113306 113306
Misses 6030 6030
Continue to review full report at Codecov.
|
devbww
reviewed
Feb 7, 2022
The googleapis RPCs can define "method signatures" which decompose a proto `request` object into its key parameters. The generator maps these to overloads, and adds the `Options options` parameter. This does not work when one of the arguments defined in the method signature is already called `options`. This changes the extract `Options options` parameter to `Options opts`, which, as of this writing, does not have any conflicts in the googleapis protos.
coryan
force-pushed
the
fix-generator-unique-names-for-Options-parameter
branch
from
d4fabf6 to
963ccf5
Compare
Contributor
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
devbww
approved these changes
Feb 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The googleapis RPCs can define "method signatures" which decompose a
proto
requestobject into its key parameters. The generator maps theseto overloads, and adds the
Options optionsparameter. This does notwork when one of the arguments defined in the method signature is
already called
options. This changes the extractOptions optionsparameter to
Options opts, which, as of this writing, does not haveany conflicts in the googleapis protos.
Part of the work for #8175
This change is