Skip to content

feat(spanner): support x-goog-user-project#8316

Merged
coryan merged 2 commits into
googleapis:mainfrom
coryan:feat-spanner-support-x-goog-user-project
Feb 9, 2022
Merged

feat(spanner): support x-goog-user-project#8316
coryan merged 2 commits into
googleapis:mainfrom
coryan:feat-spanner-support-x-goog-user-project

Conversation

@coryan
Copy link
Copy Markdown
Contributor

@coryan coryan commented Feb 9, 2022

Add support to override the project used for billing and accounting
purposes.

Part of the work for #8284


This change is Reviewable

Add support to override the project used for billing and accounting
purposes.
@product-auto-label product-auto-label Bot added the api: spanner Issues related to the Spanner API. label Feb 9, 2022
@google-cloud-cpp-bot
Copy link
Copy Markdown
Contributor

Google Cloud Build Logs
For commit: 87b45703db3dc039798e7ce35d43ece2e81cad5e

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 9, 2022

Codecov Report

Merging #8316 (76dd3ae) into main (ddb6a23) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8316   +/-   ##
=======================================
  Coverage   94.96%   94.97%           
=======================================
  Files        1344     1345    +1     
  Lines      119814   119817    +3     
=======================================
+ Hits       113786   113794    +8     
+ Misses       6028     6023    -5     
Impacted Files Coverage Δ
google/cloud/spanner/internal/defaults.cc 100.00% <100.00%> (ø)
google/cloud/spanner/internal/defaults_test.cc 100.00% <100.00%> (ø)
google/cloud/completion_queue_test.cc 96.95% <0.00%> (-0.20%) ⬇️
google/cloud/testing_util/scoped_environment.h 100.00% <0.00%> (ø)
...le/cloud/storage/internal/curl_download_request.cc 89.04% <0.00%> (+0.35%) ⬆️
google/cloud/storage/internal/curl_handle.cc 73.03% <0.00%> (+0.56%) ⬆️
google/cloud/bigtable/internal/common_client.h 100.00% <0.00%> (+5.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddb6a23...76dd3ae. Read the comment docs.

@coryan coryan marked this pull request as ready for review February 9, 2022 15:55
@coryan coryan requested a review from a team February 9, 2022 15:55
Copy link
Copy Markdown
Member

@dbolduc dbolduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can/should we test this feature in spanner?

@google-cloud-cpp-bot
Copy link
Copy Markdown
Contributor

Google Cloud Build Logs
For commit: 76dd3aeca550ba1796185b93c6c05c0542372c96

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan enabled auto-merge (squash) February 9, 2022 16:27
@coryan coryan merged commit 0e23992 into googleapis:main Feb 9, 2022
@coryan coryan deleted the feat-spanner-support-x-goog-user-project branch February 9, 2022 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the Spanner API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants