feat(common): Add converting constructors for future#8329
Conversation
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #8329 +/- ##
==========================================
- Coverage 95.09% 95.08% -0.02%
==========================================
Files 1360 1360
Lines 121124 121136 +12
==========================================
- Hits 115185 115181 -4
- Misses 5939 5955 +16
Continue to review full report at Codecov.
|
coryan
left a comment
There was a problem hiding this comment.
The robots have things to say, I agree with my robot overlords.
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
|
Can you please rebase? We have been making a lot of changes to our builds and you are missing some support scripts / changes. |
|
Ping. |
When the value type of a future is convertible to the value type of another, this allows the futures to interconvert. This is useful with, for example, make_ready_future, where one could return `make_ready_future(absl::nullopt)` for a return type of `future<absl::optional<Result>>`
1d4f49f to
fd03071
Compare
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Done. |
When the value type of a future is convertible to the value type of another, this allows the futures to interconvert.
This is useful with, for example, make_ready_future, where one could return
make_ready_future(absl::nullopt)for a return type offuture<absl::optional<Result>>This change is