Skip to content

doc(storage): show how to configure endpoints#8354

Merged
coryan merged 2 commits into
googleapis:mainfrom
coryan:doc-storage-new-endpoint-example
Feb 12, 2022
Merged

doc(storage): show how to configure endpoints#8354
coryan merged 2 commits into
googleapis:mainfrom
coryan:doc-storage-new-endpoint-example

Conversation

@coryan
Copy link
Copy Markdown
Contributor

@coryan coryan commented Feb 11, 2022

Fixes #8353


This change is Reviewable

@product-auto-label product-auto-label Bot added the api: storage Issues related to the Cloud Storage API. label Feb 11, 2022
@google-cloud-cpp-bot
Copy link
Copy Markdown
Contributor

Google Cloud Build Logs
For commit: 34d7a1060a3733a2ad4d404f9d5432493669041f

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@snippet-bot
Copy link
Copy Markdown

snippet-bot Bot commented Feb 11, 2022

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 11, 2022

Codecov Report

Merging #8354 (124fcf9) into main (45a60a6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8354   +/-   ##
=======================================
  Coverage   94.99%   94.99%           
=======================================
  Files        1355     1355           
  Lines      120964   120977   +13     
=======================================
+ Hits       114910   114926   +16     
+ Misses       6054     6051    -3     
Impacted Files Coverage Δ
google/cloud/storage/client.h 99.79% <ø> (ø)
.../examples/storage_client_initialization_samples.cc 100.00% <100.00%> (ø)
google/cloud/bigtable/internal/common_client.cc 95.71% <0.00%> (-1.43%) ⬇️
...integration_tests/schema_admin_integration_test.cc 98.88% <0.00%> (-1.12%) ⬇️
google/cloud/pubsub/samples/samples.cc 92.10% <0.00%> (-0.24%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 98.25% <0.00%> (+0.49%) ⬆️
.../cloud/storage/benchmarks/throughput_experiment.cc 74.87% <0.00%> (+0.50%) ⬆️
...ud/spanner/integration_tests/client_stress_test.cc 86.18% <0.00%> (+0.65%) ⬆️
...le/cloud/storage/internal/curl_download_request.cc 90.10% <0.00%> (+1.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45a60a6...124fcf9. Read the comment docs.

@coryan coryan marked this pull request as ready for review February 11, 2022 22:35
@coryan coryan requested a review from a team February 11, 2022 22:35
@coryan
Copy link
Copy Markdown
Contributor Author

coryan commented Feb 11, 2022

/cc @Breathtender

@google-cloud-cpp-bot
Copy link
Copy Markdown
Contributor

Google Cloud Build Logs
For commit: 124fcf94af4abb37acdb3116481862d9f2b197c0

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan enabled auto-merge (squash) February 11, 2022 23:53
@coryan coryan merged commit 0d2de98 into googleapis:main Feb 12, 2022
@coryan coryan deleted the doc-storage-new-endpoint-example branch February 12, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sample request: setting endpoint on storage client

3 participants