Skip to content

feat(pubsub): per-call options in SchemaAdminClient#8406

Merged
coryan merged 1 commit into
googleapis:mainfrom
coryan:feat-pubsub-support-options-in-schema-admin-client
Feb 18, 2022
Merged

feat(pubsub): per-call options in SchemaAdminClient#8406
coryan merged 1 commit into
googleapis:mainfrom
coryan:feat-pubsub-support-options-in-schema-admin-client

Conversation

@coryan
Copy link
Copy Markdown
Contributor

@coryan coryan commented Feb 17, 2022

Part of the work #7689


This change is Reviewable

@product-auto-label product-auto-label Bot added the api: pubsub Issues related to the Pub/Sub API. label Feb 17, 2022
@google-cloud-cpp-bot
Copy link
Copy Markdown
Contributor

Google Cloud Build Logs
For commit: c189c2a7acfbabb8df06cc7b53dd689a3b65a005

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 17, 2022

Codecov Report

Merging #8406 (c189c2a) into main (5837957) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8406   +/-   ##
=======================================
  Coverage   95.04%   95.05%           
=======================================
  Files        1358     1359    +1     
  Lines      121163   121191   +28     
=======================================
+ Hits       115162   115195   +33     
+ Misses       6001     5996    -5     
Impacted Files Coverage Δ
google/cloud/pubsub/schema_admin_client.cc 100.00% <100.00%> (ø)
google/cloud/pubsub/schema_admin_client_test.cc 100.00% <100.00%> (ø)
google/cloud/pubsub/schema_admin_connection.cc 95.91% <100.00%> (+6.12%) ⬆️
google/cloud/pubsub/schema_admin_connection.h 100.00% <100.00%> (ø)
google/cloud/pubsub/subscriber_connection_test.cc 97.22% <0.00%> (-0.70%) ⬇️
.../cloud/storage/benchmarks/throughput_experiment.cc 74.37% <0.00%> (-0.51%) ⬇️
...le/cloud/internal/default_completion_queue_impl.cc 97.72% <0.00%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5837957...c189c2a. Read the comment docs.

@coryan coryan marked this pull request as ready for review February 17, 2022 17:59
@coryan coryan requested a review from a team February 17, 2022 17:59
@coryan
Copy link
Copy Markdown
Contributor Author

coryan commented Feb 17, 2022

@devbww please let me know if this is the pattern I should follow for the other *Client classes in Pub/Sub

@coryan coryan merged commit d6e0897 into googleapis:main Feb 18, 2022
@coryan coryan deleted the feat-pubsub-support-options-in-schema-admin-client branch February 18, 2022 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the Pub/Sub API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants