fix(spanner): instantiate OptionsSpan objects in legacy admin calls#8440
Merged
Merged
Conversation
This doesn't change the legacy Spanner database/instance admin APIs at all, but it does ensure that the connection options have been installed in an `OptionsSpan` over calls into the library. Fixes googleapis#8438 and googleapis#8439.
Contributor
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #8440 +/- ##
=======================================
Coverage 95.09% 95.09%
=======================================
Files 1366 1368 +2
Lines 122339 122405 +66
=======================================
+ Hits 116335 116404 +69
+ Misses 6004 6001 -3
Continue to review full report at Codecov.
|
coryan
approved these changes
Feb 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This doesn't change the legacy Spanner database/instance admin APIs at
all, but it does ensure that the connection options have been installed
in an
OptionsSpanover calls into the library.Fixes #8438 and #8439.
This change is