-
Notifications
You must be signed in to change notification settings - Fork 432
refactor(oauth2): add current time injection point for testing #8445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(oauth2): add current time injection point for testing #8445
Conversation
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #8445 +/- ##
==========================================
- Coverage 95.09% 95.09% -0.01%
==========================================
Files 1367 1367
Lines 122501 122520 +19
==========================================
+ Hits 116491 116508 +17
- Misses 6010 6012 +2
Continue to review full report at Codecov.
|
| RefreshingCredentialsWrapper::RefreshingCredentialsWrapper( | ||
| CurrentTimeFn current_time_fn) | ||
| : current_time_fn_(std::move(current_time_fn)) {} | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it seems that the now parameter becomes redundant? Your call.
scotthart
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on @coryan)
google/cloud/internal/oauth2_refreshing_credentials_wrapper.cc, line 26 at r1 (raw file):
Previously, coryan (Carlos O'Ryan) wrote…
Thanks, it seems that the
nowparameter becomes redundant? Your call.
Removed the now parameter and just calling current_time_fn where needed.
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
coryan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @scotthart)
coryan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @scotthart)
fixes #8288
This change is