Skip to content

Conversation

@coryan
Copy link
Contributor

@coryan coryan commented Feb 25, 2022

When using PSC (Private Service Connect) or VPC-SC (Virtual Private
Cloud - Service Controls) we need to specify the authority in each
gRPC request. This is the HTTP/2 analog of a Host header, and allows
applications to access a service while using a custom endpoint. For
example, the target endpoint could be pubsub-custom.p.googleapis.com,
but the authority field remains pubsub.googleapis.com.

Part of the work for #3317


This change is Reviewable

When using [PSC] (Private Service Connect) or [VPC-SC] (Virtual Private
Cloud - Service Controls) we need to specify the `authority` in each
gRPC request. This is the HTTP/2 analog of a `Host` header, and allows
applications to access a service while using a custom endpoint. For
example, the target endpoint could be `pubsub-custom.p.googleapis.com`,
but the authority field remains `pubsub.googleapis.com`.

[PSC]: https://cloud.google.com/vpc/docs/private-service-connect
[VPC-SC]: https://cloud.google.com/vpc-service-controls
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: f5f19b677c8749dbeafa3be3a17eeb5882ebc10d

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

There is no default endpoint for Pub/Sub Lite, we need to explicitly set
the authority.
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 602c005d7b4fc0ecf8039cc4397e23a1a089a5b3

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #8453 (404f811) into main (291e9dd) will decrease coverage by 0.00%.
The diff coverage is 54.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8453      +/-   ##
==========================================
- Coverage   93.85%   93.85%   -0.01%     
==========================================
  Files        1444     1444              
  Lines      124189   124223      +34     
==========================================
+ Hits       116562   116587      +25     
- Misses       7627     7636       +9     
Impacted Files Coverage Δ
generator/internal/metadata_decorator_generator.cc 59.37% <ø> (ø)
...ud/pubsublite/internal/admin_metadata_decorator.cc 0.00% <0.00%> (ø)
...d/pubsublite/internal/cursor_metadata_decorator.cc 0.00% <0.00%> (ø)
...nternal/partition_assignment_metadata_decorator.cc 0.00% <0.00%> (ø)
...ubsublite/internal/publisher_metadata_decorator.cc 0.00% <0.00%> (ø)
...bsublite/internal/subscriber_metadata_decorator.cc 0.00% <0.00%> (ø)
...sublite/internal/topic_stats_metadata_decorator.cc 0.00% <0.00%> (ø)
...internal/golden_kitchen_sink_metadata_decorator.cc 84.09% <50.00%> (-1.63%) ⬇️
.../internal/golden_thing_admin_metadata_decorator.cc 96.38% <50.00%> (-1.15%) ⬇️
google/cloud/internal/populate_common_options.cc 100.00% <100.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 291e9dd...404f811. Read the comment docs.

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 404f81196973568c2e121c6913228f823210b8bb

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

Copy link
Member

@dbolduc dbolduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for figuring this out. The changes LGTM.

I was confused by the scope of the PR (generated metadata decorators + spanner) but I see that you have a handle on the remaining work in the issue description.

@coryan coryan marked this pull request as ready for review February 25, 2022 16:04
@coryan coryan requested a review from a team as a code owner February 25, 2022 16:04
@coryan coryan added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 25, 2022
@google-cloud-cpp-bot google-cloud-cpp-bot removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 25, 2022
@coryan coryan enabled auto-merge (squash) February 25, 2022 18:44
@coryan coryan merged commit 62b48c4 into googleapis:main Feb 25, 2022
@coryan coryan deleted the feat-common-authority-option branch February 25, 2022 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants