-
Notifications
You must be signed in to change notification settings - Fork 432
feat: better support for PSC and VPC-SC #8453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When using [PSC] (Private Service Connect) or [VPC-SC] (Virtual Private Cloud - Service Controls) we need to specify the `authority` in each gRPC request. This is the HTTP/2 analog of a `Host` header, and allows applications to access a service while using a custom endpoint. For example, the target endpoint could be `pubsub-custom.p.googleapis.com`, but the authority field remains `pubsub.googleapis.com`. [PSC]: https://cloud.google.com/vpc/docs/private-service-connect [VPC-SC]: https://cloud.google.com/vpc-service-controls
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
There is no default endpoint for Pub/Sub Lite, we need to explicitly set the authority.
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #8453 +/- ##
==========================================
- Coverage 93.85% 93.85% -0.01%
==========================================
Files 1444 1444
Lines 124189 124223 +34
==========================================
+ Hits 116562 116587 +25
- Misses 7627 7636 +9
Continue to review full report at Codecov.
|
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
dbolduc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for figuring this out. The changes LGTM.
I was confused by the scope of the PR (generated metadata decorators + spanner) but I see that you have a handle on the remaining work in the issue description.
When using PSC (Private Service Connect) or VPC-SC (Virtual Private
Cloud - Service Controls) we need to specify the
authorityin eachgRPC request. This is the HTTP/2 analog of a
Hostheader, and allowsapplications to access a service while using a custom endpoint. For
example, the target endpoint could be
pubsub-custom.p.googleapis.com,but the authority field remains
pubsub.googleapis.com.Part of the work for #3317
This change is