feat(pubsub): support x-goog-user-project #8456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the metadata decorators to inject `x-goog-user-project` from the current option span. For the admin APIs, use the per-call options to configure a span in the `*Client` class. For `pubsub::Publisher` and `pubsub::Subscriber` it is less clear which call "triggers" an RPC, and far less clear how to merge options from multiple RPCs. I have decided to use the per-connection options in this case. We can always add more fine-grained options later, but this takes care of the common case.
Collaborator
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #8456 +/- ##
==========================================
+ Coverage 93.84% 93.87% +0.02%
==========================================
Files 1444 1444
Lines 124227 124611 +384
==========================================
+ Hits 116583 116974 +391
+ Misses 7644 7637 -7
Continue to review full report at Codecov.
|
devbww
reviewed
Feb 25, 2022
Collaborator
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
devbww
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the metadata decorators to inject
x-goog-user-projectfrom thecurrent option span.
For the admin APIs, use the per-call options to configure a span in the
*Clientclass. Forpubsub::Publisherandpubsub::Subscriberit isless clear which call "triggers" an RPC, and far less clear how to merge
options from multiple RPCs. I have decided to use the per-connection
options in this case. We can always add more fine-grained options later,
but this takes care of the common case.
Part of the work for #8284 and will help with #3317
This change is