docs(maps): correct the samples#14632
Merged
Merged
Conversation
product-auto-label
Bot
added
the
samples
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the librarian.yaml configuration to omit snippets for several Maps APIs and modifies the maps/README.md to update the code samples link. A review comment suggests that the new link in the README is too specific for the entire module and recommends providing both the general and specific sample links to ensure all users can find relevant resources.
| ## Google Cloud Samples | ||
|
|
||
| To browse ready to use code samples check [Google Cloud Samples](https://cloud.google.com/docs/samples?l=go). | ||
| To browse ready to use code samples check [Places API (New) client library examples](https://developers.google.com/maps/documentation/places/web-service/client-library-examples#go). |
Contributor
There was a problem hiding this comment.
The updated link is specific to the Places API (New), but this README covers the entire maps module, which includes other APIs like Route Optimization and Solar. Replacing the general samples search link with a specific one makes it harder for users of these other APIs to find relevant samples. Consider keeping the general link alongside the specific one to ensure users of all APIs in this module can find relevant resources.
Suggested change
| To browse ready to use code samples check [Places API (New) client library examples](https://developers.google.com/maps/documentation/places/web-service/client-library-examples#go). | |
| To browse ready to use code samples check [Google Cloud Samples](https://cloud.google.com/docs/samples?l=go) or the [Places API (New) client library examples](https://developers.google.com/maps/documentation/places/web-service/client-library-examples#go). |
hongalex
approved these changes
May 22, 2026
bhshkh
added a commit
to bhshkh/google-cloud-go
that referenced
this pull request
May 22, 2026
This reverts commit 7988942.
bhshkh
added a commit
that referenced
this pull request
May 23, 2026
This reverts commit 7988942. Reason: https://chat.google.com/room/AAAAyD3sMh0/NFogF4VR75M
bhshkh
pushed a commit
that referenced
this pull request
May 28, 2026
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v0.15.0 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go@sha256:b04b076f5eedbb5546bd6fc1404969dd3698c8b19c0f34ae815a84ae735a606a <details><summary>dataplex: v1.35.0</summary> ## [v1.35.0](dataplex/v1.34.0...dataplex/v1.35.0) (2026-05-28) ### Features * update API sources and regenerate (#14661) ([d0cd917](d0cd917c)) </details> <details><summary>geminidataanalytics: v1.2.0</summary> ## [v1.2.0](geminidataanalytics/v1.1.0...geminidataanalytics/v1.2.0) (2026-05-28) ### Features * update API sources and regenerate (#14661) ([d0cd917](d0cd917c)) </details> <details><summary>maps: v1.36.0</summary> ## [v1.36.0](maps/v1.35.0...maps/v1.36.0) (2026-05-28) ### Features * update API sources and regenerate (#14661) ([d0cd917](d0cd917c)) ### Documentation * correct the samples (#14632) ([7988942](7988942c)) </details> <details><summary>saasplatform: v0.8.0</summary> ## [v0.8.0](saasplatform/v0.7.0...saasplatform/v0.8.0) (2026-05-28) ### Features * update API sources and regenerate (#14661) ([d0cd917](d0cd917c)) </details> <details><summary>security: v1.25.0</summary> ## [v1.25.0](security/v1.24.0...security/v1.25.0) (2026-05-28) ### Features * update API sources and regenerate (#14661) ([d0cd917](d0cd917c)) </details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: b/421113149