The generated samples in each GAPIC client library show use cases of try-with resources. Example:
|
* try (NetworkServiceClient networkServiceClient = NetworkServiceClient.create()) { |
While this is a good example as a sample to show how a client is created and closed without incurring memory leaks, it may provide our users with an incorrect idea of how to create clients. We expect client libraries to be long-lived and not to be re-created/ closed repeatedly.
We should update the samples with a few options:
- Samples are updated to not use try-with-resources
- Samples have wording to describe that they are for example purposed and link to the official docs
- ... Other options?
High Level Changes:
The samples from the GAPIC clients are generated from the generator. Based on the option we choose, we'll have to update the generator accordingly.
The generated samples in each GAPIC client library show use cases of try-with resources. Example:
google-cloud-java/java-admanager/ad-manager/src/main/java/com/google/ads/admanager/v1/NetworkServiceClient.java
Line 325 in 7346a85
While this is a good example as a sample to show how a client is created and closed without incurring memory leaks, it may provide our users with an incorrect idea of how to create clients. We expect client libraries to be long-lived and not to be re-created/ closed repeatedly.
We should update the samples with a few options:
High Level Changes:
The samples from the GAPIC clients are generated from the generator. Based on the option we choose, we'll have to update the generator accordingly.