dependency compatibility test is failing

[blakeli0]

dependency compatibility test is failing due to the following error

Slf4jUtilsTest.testGetLogger_loggingDisabled_shouldGetNOPLogger:61 expected: <org.slf4j.helpers.NOPLogger> but was: <com.google.api.gax.logging.TestLogger>

However, this file was not touched in a while and it was never flaky. I suspect it is because of recent changes of the scripts in sdk-platform-java-dependency_compatibility_test.yaml.
See the error log for details.

[chingor13]

Locally, I can repro with mvn install -Dcheckstyle.skip -pl sdk-platform-java/gax-java/gax -Djacoco.skip after installing the sdk-platform-java modules

[chingor13]

Strangely, mvn install -Dcheckstyle.skip -Djacoco.skip also fails at head for googleapis/sdk-platform-java

[chingor13]

I think this is a real test failure having to do with global logger configuration introduced with the observability tracing implementation. sdk-platform-java's test is also failing after backporting changes in googleapis/sdk-platform-java#4170

[chingor13]

Test:

google-cloud-java/sdk-platform-java/gax-java/gax/src/test/java/com/google/api/gax/logging/Slf4jUtilsTest.java

Lines 58 to 64 in 8095342

	@Test
	void testGetLogger_loggingDisabled_shouldGetNOPLogger() {
	Logger logger = Slf4jUtils.getLogger(Slf4jUtilsTest.class);
	assertEquals(NOPLogger.class, logger.getClass());
	assertFalse(logger.isInfoEnabled());
	assertFalse(logger.isDebugEnabled());
	}

This test is fetching the logger from SlftjUtils which is using the static LoggerFactory.getILoggerFactory() from slf4j

Other code is likely configuring this logger, so we do not see the NoopLogger expected by the test

[chingor13]

To unblock this, we will disable the check and follow up on the test in #12836

[blakeli0]

Why this does not fail in sdk-platform-java-ci?

[chingor13]

Why this does not fail in sdk-platform-java-ci?

It has been https://github.com/googleapis/sdk-platform-java/actions/workflows/dependency_compatibility_test.yaml