Skip to content

Update to GAX 1.7.0 and 0.24.0#2420

Merged
shinfan merged 2 commits intogoogleapis:masterfrom
shinfan:master
Sep 11, 2017
Merged

Update to GAX 1.7.0 and 0.24.0#2420
shinfan merged 2 commits intogoogleapis:masterfrom
shinfan:master

Conversation

@shinfan
Copy link
Copy Markdown
Contributor

@shinfan shinfan commented Sep 8, 2017

  • Sync with api-client-staging
  • Make compatibility changes to GAX 1.7.0 and 0.24.0 (Explicit exception types)

@shinfan shinfan requested a review from vam-google September 8, 2017 23:16
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 8, 2017
vam-google
vam-google approved these changes Sep 8, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

google-cloud-core-grpc/src/test/java/com/google/cloud/grpc/BaseGrpcServiceExceptionTest.java Outdated
Exception cause = new IllegalArgumentException("bad arg");
GrpcApiException apiException =
new GrpcApiException(MESSAGE, cause, Code.INTERNAL, NOT_RETRYABLE);
ApiException apiException =

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

vam-google
vam-google approved these changes Sep 9, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shinfan
Copy link
Copy Markdown
Contributor Author

shinfan commented Sep 10, 2017

The travis failed but I don't think it is caused by this particular PR and I could not reproduce the failure on my local environment (all tests passed on my machine):

java.lang.AssertionError: 
  Unexpected method call Logging.write([LogEntry{logName=null, resource=null, timestamp=123456789, receiveTimestamp=null, severity=DEBUG, insertId=null, httpRequest=null, labels={levelName=FINEST, levelValue=300}, operation=null, trace=null, sourceLocation=null, payload=StringPayload{type=STRING, data=message}}], WriteOption{name=LOG_NAME, value=java.log}, WriteOption{name=RESOURCE, value=MonitoredResource{type=gce_instance, labels={instance_id=2185756361539269989, project_id=project, zone=us-central1-c}}}, WriteOption{name=LABELS, value={levelName=INFO, levelValue=800}}):
    Logging.write([LogEntry{logName=null, resource=null, timestamp=123456789, receiveTimestamp=null, severity=DEBUG, insertId=null, httpRequest=null, labels={levelName=FINEST, levelValue=300}, operation=null, trace=null, sourceLocation=null, payload=StringPayload{type=STRING, data=message}}], WriteOption{name=LOG_NAME, value=java.log}, WriteOption{name=RESOURCE, value=MonitoredResource{type=global, labels={project_id=project}}}, WriteOption{name=LABELS, value={levelName=INFO, levelValue=800}}):

Adding @pongad since PR #2420 is having a similar issue.

@pongad
Copy link
Copy Markdown
Contributor

pongad commented Sep 10, 2017

@shinfan I'm not sure what's causing the error, but I agree that we can be pretty sure it's not this PR.

@shinfan
Copy link
Copy Markdown
Contributor Author

shinfan commented Sep 11, 2017

This is blocking the release. I will go ahead and merge soon if there is no objections. @vam-google

@shinfan shinfan merged commit 099118e into googleapis:master Sep 11, 2017
chingor13 pushed a commit that referenced this pull request Feb 20, 2026
@lqiu96
feat: next release from main branch is 2.48.0 (#2420)
2dd8efc
chingor13 pushed a commit that referenced this pull request Feb 20, 2026
@release-please
chore(main): release 3.3.0 (#2415)
023df3b 
🤖 I have created a release *beep* *boop*
---


## [3.3.0](https://togithub.com/googleapis/java-bigquerystorage/compare/v3.2.0...v3.3.0) (2024-03-04)


### Features

* Add RetrySettings use to Write API samples. ([#2419](https://togithub.com/googleapis/java-bigquerystorage/issues/2419)) ([5b000d0](https://togithub.com/googleapis/java-bigquerystorage/commit/5b000d0a4e953649ca4e44bffd3ba25c288e70e4))
* Add the RANGE type to the google.cloud.bigquery.storage.v1.TableFieldSchema ([#2413](https://togithub.com/googleapis/java-bigquerystorage/issues/2413)) ([6aa92b5](https://togithub.com/googleapis/java-bigquerystorage/commit/6aa92b5d03eed548de9e89b0731707f92c373ce3))
* Next release from main branch is 2.48.0 ([#2420](https://togithub.com/googleapis/java-bigquerystorage/issues/2420)) ([2dd8efc](https://togithub.com/googleapis/java-bigquerystorage/commit/2dd8efc4a21f186c20e86304092d22fd574e822e))


### Bug Fixes

* Fix issue where Universe Domain is not correctly set. ([#2423](https://togithub.com/googleapis/java-bigquerystorage/issues/2423)) ([b7ebd73](https://togithub.com/googleapis/java-bigquerystorage/commit/b7ebd73754fe51a4835f676e429b95b80f8114a5))


### Dependencies

* Update dependency com.google.cloud:google-cloud-bigquery to v2.38.0 ([#2417](https://togithub.com/googleapis/java-bigquerystorage/issues/2417)) ([8184a0f](https://togithub.com/googleapis/java-bigquerystorage/commit/8184a0f74e98340fe62621957f3ac78ad70c9edb))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.38.0 ([#2418](https://togithub.com/googleapis/java-bigquerystorage/issues/2418)) ([4d5eb73](https://togithub.com/googleapis/java-bigquerystorage/commit/4d5eb7343cdf5fd617a2da120642bfd678d58f94))
* Update dependency com.google.truth:truth to v1.4.1 ([#2412](https://togithub.com/googleapis/java-bigquerystorage/issues/2412)) ([c2dcb73](https://togithub.com/googleapis/java-bigquerystorage/commit/c2dcb73c54ad5dcb68ce18741efaf479298373e1))
* Update dependency com.google.truth:truth to v1.4.2 ([#2424](https://togithub.com/googleapis/java-bigquerystorage/issues/2424)) ([7a12de0](https://togithub.com/googleapis/java-bigquerystorage/commit/7a12de0ebc6a0a0f4bb438e3dcb36ee0759c0b94))
* Update dependency org.graalvm.buildtools:native-maven-plugin to v0.10.1 ([#2414](https://togithub.com/googleapis/java-bigquerystorage/issues/2414)) ([dfa8d53](https://togithub.com/googleapis/java-bigquerystorage/commit/dfa8d532e5e1a28d644fefed6650ca1a2481a3a3))
* Update dependency org.json:json to v20240303 ([#2426](https://togithub.com/googleapis/java-bigquerystorage/issues/2426)) ([2accca7](https://togithub.com/googleapis/java-bigquerystorage/commit/2accca72f2bd26c9a1cf1bd918961889b9ee3ace))


### Documentation

* Mark BigQueryWrite v1beta2 as deprecated ([#2421](https://togithub.com/googleapis/java-bigquerystorage/issues/2421)) ([07d98ab](https://togithub.com/googleapis/java-bigquerystorage/commit/07d98ab417ae9fd2f90aca4d6a1a3ff62ef0bc1d))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 23, 2026
@rayudu3745
fix: fix getLong on NUMERIC (googleapis#2420)
75ec5c2 
* fix: fix getLong on NUMERIC

* address review comments
@ldetmer ldetmer mentioned this pull request Mar 31, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@garrettjonesgoogle garrettjonesgoogle Awaiting requested review from garrettjonesgoogle

1 more reviewer

@vam-google vam-google vam-google approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shinfan @pongad @vam-google @googlebot