-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Closed
Labels
api: spannerIssues related to the Spanner API.Issues related to the Spanner API.type: cleanupAn internal cleanup or hygiene concern.An internal cleanup or hygiene concern.
Description
Environment details
- Specify the API at the beginning of the title (for example, "BigQuery: ...")
General, Core, and Other are also allowed as types - OS type and version: OSX
- Java version: java 8
- google-cloud-java version(s): google-cloud-spanner-jdbc:1.7.0
Steps to reproduce
- Add dependnecy to google-cloud-spanner-jdbc:1.7.0
- See the dependency tree, e.g.
mvn dependency:tree -Dverbose
Code example
N/A
Stack trace
N/A
External references such as API reference guides used
N/A
Any additional information below
Spanner JDBC driver pulls in cloud storage dependency. This seems excess for a JDBC driver.
According to @olavloite this is used for potentially fetching credentials from GCS.
Master branch currently has the dependency marked as scope provided. However, the semantic of provided scope doesn't seem to match the intended meaning.
- Dependency should be marked as
optional(<optional>true</optional>) - Consider removing this dependency (and functionality) altogether. It's not documented, nor is it a JDBC driver's responsibility to fetch credentials from a remote storage.
Metadata
Metadata
Assignees
Labels
api: spannerIssues related to the Spanner API.Issues related to the Spanner API.type: cleanupAn internal cleanup or hygiene concern.An internal cleanup or hygiene concern.