Skip to content

Conversation

@JoeWang1127
Copy link
Contributor

@JoeWang1127 JoeWang1127 commented Mar 11, 2024

In this PR:

  • Sort entries in pom.xml and gapic-libaries-bom/pom.xml

Context: this is a preparation step for hermetic build launch plan.

@JoeWang1127 JoeWang1127 added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 11, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 11, 2024
@JoeWang1127
Copy link
Contributor Author

"generation diff/root-pom" and "generation diff/gapic-bom" are expected to fail.

@JoeWang1127 JoeWang1127 marked this pull request as ready for review March 11, 2024 15:05
@JoeWang1127 JoeWang1127 requested a review from a team as a code owner March 11, 2024 15:05
@JoeWang1127 JoeWang1127 requested a review from suztomo March 11, 2024 15:08
@suztomo
Copy link
Member

suztomo commented Mar 11, 2024

"generation diff/root-pom" and "generation diff/gapic-bom" are expected to fail.

What's the plan? I think they are already sorted. It's just different order than this pull request.

@JoeWang1127
Copy link
Contributor Author

What's the plan? I think they are already sorted. It's just different order than this pull request.

I think the order is different when sorting a string using shell and python. This PR can reduce the amount of irrelvant difference in the initial generation made by hermetic build project.

@JoeWang1127 JoeWang1127 enabled auto-merge (squash) March 11, 2024 15:21
@JoeWang1127 JoeWang1127 merged commit add8caf into main Mar 11, 2024
@JoeWang1127 JoeWang1127 deleted the chore/format-pom branch March 11, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants