chore(scripts): check PR mergeable state before merging#12219
Merged
jinseopkim0 merged 2 commits intomainfrom Mar 27, 2026
Merged
chore(scripts): check PR mergeable state before merging#12219jinseopkim0 merged 2 commits intomainfrom
jinseopkim0 merged 2 commits intomainfrom
Conversation
The release manager merge bot was previously failing with a 405 error when a PR's combined status was "success" but required checks (like GitHub Actions check runs) or reviews were still missing.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enhances the release manager merge bot by incorporating checks for the pull request's mergeable state. It now explicitly handles 'dirty' and 'draft' states as fatal errors and introduces a waiting mechanism when the mergeable state is 'blocked', 'behind', or pending calculation. A review comment suggests refactoring the logic to avoid the use of a goto statement for retrying, recommending more idiomatic Go control flow structures to improve maintainability.
blakeli0
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release manager merge bot was previously failing with an error when a PR's combined status was "success" but required checks (like GitHub Actions check runs) or reviews were still missing.