Skip to content

ci: fix paths for nightly sdk-platform-java builds#12338

Merged
chingor13 merged 6 commits intomainfrom
fix-nightly
Apr 1, 2026
Merged

ci: fix paths for nightly sdk-platform-java builds#12338
chingor13 merged 6 commits intomainfrom
fix-nightly

Conversation

@chingor13
Copy link
Copy Markdown
Contributor

@chingor13 chingor13 commented Mar 31, 2026

  • The nightly sdk-platform-java tests should run nightly regardless of whether the last commit touched that folder. Thus we remove the filter that was added during migration
  • The nightly test is now scoped to just the sdk-platform-java test, but we need to install the necessary dependencies first

Tested with workflow_dispatch: https://github.com/googleapis/google-cloud-java/actions/runs/23858827062

Fixes #12206

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the --also-make flag to Maven installation commands in .kokoro/common.sh. A review comment identifies that this flag is redundant when building the entire project without specific module selection and suggests removing it to avoid Maven warnings.

@chingor13 chingor13 marked this pull request as ready for review March 31, 2026 20:54
@chingor13 chingor13 requested a review from a team as a code owner March 31, 2026 20:54
@chingor13 chingor13 enabled auto-merge (squash) March 31, 2026 21:10
@chingor13 chingor13 requested a review from zhumin8 March 31, 2026 21:56
@chingor13 chingor13 requested a review from blakeli0 April 1, 2026 16:26
@chingor13 chingor13 merged commit 0432a49 into main Apr 1, 2026
110 checks passed
@chingor13 chingor13 deleted the fix-nightly branch April 1, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nightly-java8 build on ubuntu-22.04 failed.

2 participants