Skip to content

feat: [geocode] new module for geocode#12343

Merged
diegomarquezp merged 4 commits intomainfrom
new-library/geocode-h1DIk
Apr 1, 2026
Merged

feat: [geocode] new module for geocode#12343
diegomarquezp merged 4 commits intomainfrom
new-library/geocode-h1DIk

Conversation

@cloud-java-bot
Copy link
Copy Markdown
Collaborator

Generated by @diegomarquezp via generate_new_client_hermetic_build.yaml

Command used:

python generation/new_client_hermetic_build/add-new-client-config.py add-new-library --api-shortname "geocode" --name-pretty "Geocoding API" --api-description "The Geocoding API is a service that accepts a place as an address, latitude and longitude coordinates, or Place ID." --proto-path "google/maps/geocode/v4" --product-docs "https://developers.google.com/maps/documentation/geocoding/overview" --library-name "maps-geocode" --distribution-name "com.google.maps:google-maps-geocode" 

@cloud-java-bot cloud-java-bot requested a review from a team as a code owner March 31, 2026 21:28
@cloud-java-bot cloud-java-bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 31, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reformats generation_config.yaml by moving documentation URLs to new lines and updating string quoting for several API descriptions. It also introduces a new entry for the Geocoding API. Feedback was provided to ensure the new geocode entry follows the same URL formatting consistency as the other modified entries.

Comment on lines +1625 to +1628
product_documentation: https://developers.google.com/maps/documentation/geocoding/overview
api_description: The Geocoding API is a service that accepts a place as an address,
latitude and longitude coordinates, or Place ID.
client_documentation: https://cloud.google.com/java/docs/reference/google-maps-geocode/latest/overview
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The product_documentation and client_documentation URLs for the new geocode module are defined on a single line. This is inconsistent with the formatting changes applied to all other entries in this pull request, where URLs are moved to a new line with indentation. Please update these to maintain consistency across the configuration file.

  product_documentation: 
    https://developers.google.com/maps/documentation/geocoding/overview
  api_description: The Geocoding API is a service that accepts a place as an address,
    latitude and longitude coordinates, or Place ID.
  client_documentation: 
    https://cloud.google.com/java/docs/reference/google-maps-geocode/latest/overview

@snippet-bot
Copy link
Copy Markdown

snippet-bot bot commented Mar 31, 2026

Here is the summary of changes.

You are about to add 18 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@diegomarquezp diegomarquezp merged commit 474efb1 into main Apr 1, 2026
102 checks passed
@diegomarquezp diegomarquezp deleted the new-library/geocode-h1DIk branch April 1, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

owlbot:run Add this label to trigger the Owlbot post processor.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants