fix(release): add Version.java as extra files in release-please#12617
fix(release): add Version.java as extra files in release-please#12617diegomarquezp merged 1 commit intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the release-please configuration to include additional generic file paths for version tracking. The review feedback highlights an indentation inconsistency and a discrepancy between the PR title and the actual changes, providing a corrected JSON snippet to ensure proper formatting.
| { | ||
| "type": "generic", | ||
| "path": "java-*/**/Version.java", | ||
| "glob": true | ||
| }, | ||
| { | ||
| "type": "generic", | ||
| "path": "sdk-platform-java/java-showcase*/Version.java", | ||
| "glob": true | ||
| }, |
There was a problem hiding this comment.
The indentation in the newly added blocks uses a mix of tabs and spaces, which is inconsistent with the 2-space indentation used in the rest of the file. Additionally, please ensure that configuration for files within submodules is placed in the root package's extra-files section, as release-please does not check for configuration within submodules. Finally, the PR title mentions 'renovate config', but these changes are for release-please. Updating the title will ensure the generated changelog is accurate.
{
"type": "generic",
"path": "java-*/**/Version.java",
"glob": true
},
{
"type": "generic",
"path": "sdk-platform-java/java-showcase*/Version.java",
"glob": true
}References
- In release-please-config.json, configuration for files within submodules should be placed in the root package's extra-files section, as release-please does not check for configuration within submodules.
There was a problem hiding this comment.
FYI, I didn't have to add the extra metadata type and glob for it to work for bigquery
There was a problem hiding this comment.
the PR title mentions 'renovate config', but these changes are for release-please
This is valid. @diegomarquezp Can you please update the PR title before merging?
There was a problem hiding this comment.
FYI, I didn't have to add the extra metadata type and glob for it to work for bigquery
I wanted to cover all Version.java files generated in google-cloud-java.
There was a problem hiding this comment.
the PR title mentions 'renovate config', but these changes are for release-please
This is valid. @diegomarquezp Can you please update the PR title before merging?
Done
| { | ||
| "type": "generic", | ||
| "path": "java-*/**/Version.java", | ||
| "glob": true | ||
| }, | ||
| { | ||
| "type": "generic", | ||
| "path": "sdk-platform-java/java-showcase*/Version.java", | ||
| "glob": true | ||
| }, |
There was a problem hiding this comment.
FYI, I didn't have to add the extra metadata type and glob for it to work for bigquery
| { | ||
| "type": "generic", | ||
| "path": "java-*/**/Version.java", | ||
| "glob": true | ||
| }, | ||
| { | ||
| "type": "generic", | ||
| "path": "sdk-platform-java/java-showcase*/Version.java", | ||
| "glob": true | ||
| }, |
There was a problem hiding this comment.
the PR title mentions 'renovate config', but these changes are for release-please
This is valid. @diegomarquezp Can you please update the PR title before merging?
diegomarquezp
changed the title
3 participants
Confirmed on dry run: