Skip to content

fix(o11y): remove gpc.client.language attribute #12621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
diegomarquezp merged 1 commit into from
Apr 2, 2026
Merged

fix(o11y): remove gpc.client.language attribute #12621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions sdk-platform-java/gax-java/gax/src/main/java/com/google/api/gax/tracing/SpanTracer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,6 @@
@BetaApi
@InternalApi
public class SpanTracer implements ApiTracer {
public static final String LANGUAGE_ATTRIBUTE = "gcp.client.language";

public static final String DEFAULT_LANGUAGE = "Java";

static final String CONTENT_LENGTH_KEY = "Content-Length";

Expand Down Expand Up @@ -103,7 +100,6 @@ private static String resolveAttemptSpanName(ApiTracerContext apiTracerContext)
}

private void buildAttributes() {
this.attemptAttributes.put(LANGUAGE_ATTRIBUTE, DEFAULT_LANGUAGE);
this.attemptAttributes.putAll(this.apiTracerContext.getAttemptAttributes());
}

Expand Down
13 changes: 0 additions & 13 deletions sdk-platform-java/gax-java/gax/src/test/java/com/google/api/gax/tracing/SpanTracerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,19 +84,6 @@ void testAttemptLifecycle_startsAndEndsAttemptSpan() {
verify(span).end();
}

@Test
void testAttemptStarted_includesLanguageAttribute() {
spanTracer.attemptStarted(new Object(), 1);

ArgumentCaptor<Attributes> attributesCaptor = ArgumentCaptor.forClass(Attributes.class);
verify(spanBuilder).setAllAttributes(attributesCaptor.capture());

assertThat(attributesCaptor.getValue().asMap())
.containsEntry(
io.opentelemetry.api.common.AttributeKey.stringKey(SpanTracer.LANGUAGE_ATTRIBUTE),
SpanTracer.DEFAULT_LANGUAGE);
}

@Test
void testAttemptSucceeded_grpc() {
ApiTracerContext context =
Expand Down
21 changes: 6 additions & 15 deletions ...a-showcase/gapic-showcase/src/test/java/com/google/showcase/v1beta1/it/ITOtelTracing.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@
import com.google.api.gax.rpc.TransportChannelProvider;
import com.google.api.gax.rpc.UnavailableException;
import com.google.api.gax.tracing.ObservabilityAttributes;
import com.google.api.gax.tracing.SpanTracer;
import com.google.api.gax.tracing.SpanTracerFactory;
import com.google.common.collect.ImmutableList;
import com.google.protobuf.InvalidProtocolBufferException;
Expand Down Expand Up @@ -134,11 +133,6 @@ void testTracing_successfulEcho_grpc() throws Exception {
.findFirst()
.orElseThrow(() -> new AssertionError("Incorrect span name"));
assertThat(attemptSpan.getKind()).isEqualTo(SpanKind.CLIENT);
assertThat(
attemptSpan
.getAttributes()
.get(AttributeKey.stringKey(SpanTracer.LANGUAGE_ATTRIBUTE)))
.isEqualTo(SpanTracer.DEFAULT_LANGUAGE);
assertThat(
attemptSpan
.getAttributes()
Expand Down Expand Up @@ -205,11 +199,6 @@ void testTracing_successfulEcho_httpjson() throws Exception {
.orElseThrow(
() -> new AssertionError("Attempt span 'POST v1beta1/echo:echo' not found"));
assertThat(attemptSpan.getKind()).isEqualTo(SpanKind.CLIENT);
assertThat(
attemptSpan
.getAttributes()
.get(AttributeKey.stringKey(SpanTracer.LANGUAGE_ATTRIBUTE)))
.isEqualTo(SpanTracer.DEFAULT_LANGUAGE);
assertThat(
attemptSpan
.getAttributes()
Expand Down Expand Up @@ -491,8 +480,9 @@ public void sendMessage(ReqT message) {}

assertThrows(UnavailableException.class, () -> client.echo(echoRequest));
verifyErrorTypeAttribute("UNAVAILABLE");
}
}
}
}

@Test
void testTracing_statusCodes_grpc() throws Exception {
SpanTracerFactory tracingFactory = new SpanTracerFactory(openTelemetrySdk);
Expand Down Expand Up @@ -626,8 +616,9 @@ public String getHeaderValue(int index) {

assertThrows(UnavailableException.class, () -> client.echo(echoRequest));
verifyErrorTypeAttribute("503");
}
}
}
}

void testTracing_statusCodes_httpjson() throws Exception {
SpanTracerFactory tracingFactory = new SpanTracerFactory(openTelemetrySdk);
EchoRequest errorRequest =
Expand Down
Loading