Conversation
There was a problem hiding this comment.
Code Review
This pull request transitions the repository from snapshot to release versions, specifically updating the project to version 1.85.0. The changes encompass updates to the release manifest, changelog, workspace settings, and version strings across numerous POM files and internal Java classes. Feedback focused on correcting metadata keys in versioning comments within the accesscontextmanager module to ensure consistent and accurate automated version tracking.
| <description>PROTO library for proto-google-identity-accesscontextmanager-type</description> | ||
| <parent> | ||
| <groupId>com.google.cloud</groupId> | ||
| <artifactId>google-identity-accesscontextmanager-parent</artifactId> |
There was a problem hiding this comment.
The version update comment for the parent project is inconsistent with other modules in this repository. It should use the main library key google-identity-accesscontextmanager:current instead of the proto-specific key proto-google-identity-accesscontextmanager-v1:current to ensure consistent automated versioning across the module.
| <artifactId>google-identity-accesscontextmanager-parent</artifactId> | |
| <version>1.92.0</version><!-- {x-version-update:google-identity-accesscontextmanager:current} --> |
| <groupId>com.google.api.grpc</groupId> | ||
| <artifactId>proto-google-identity-accesscontextmanager-type</artifactId> | ||
| <version>1.92.0-SNAPSHOT</version><!-- {x-version-update:proto-google-identity-accesscontextmanager-v1:current} --> | ||
| <version>1.92.0</version><!-- {x-version-update:proto-google-identity-accesscontextmanager-v1:current} --> |
There was a problem hiding this comment.
The version update comment for the proto-google-identity-accesscontextmanager-type dependency is incorrect. It should use the key proto-google-identity-accesscontextmanager-type:current to correctly track the version of the dependent artifact, rather than reusing the key for the current module.
| <version>1.92.0</version><!-- {x-version-update:proto-google-identity-accesscontextmanager-v1:current} --> | |
| <version>1.92.0</version><!-- {x-version-update:proto-google-identity-accesscontextmanager-type:current} --> |
🤖 I have created a release beep boop
1.85.0
1.85.0 (2026-04-14)
Features
Enginefield to support LightningEngine in (fc62b1e)base64_encoded_nameis (fc62b1e)Bug Fixes
Documentation
regionfield in (fc62b1e)namein (fc62b1e)This PR was generated with Release Please. See documentation.