test: Release please simulation testing #12848#12849
test: Release please simulation testing #12848#12849meltsufin wants to merge 1 commit intorelease-please--fix-12825from
Conversation
This commit updates the image_tag to a non-existent version (9.99.9) in hermetic_library_generation.yaml to force the pull failure and verify the fallback logic works in CI. DO NOT MERGE THIS PR
meltsufin
added
the
do not merge
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a fallback mechanism for Docker image tags in the hermetic library generation script, specifically targeting release branches. When a Docker image for the current tag is not found, the script now attempts to retrieve and use the image tag from the target branch. A review comment correctly identified that the script's 'pipefail' setting could cause it to exit prematurely if the git command or grep fails, and a suggestion was provided to ensure the fallback logic completes as intended.
|
|
1 participant
Test fallback branch in #12848