test: prevent root versions.txt from affecting postprocessor test fixtures#12853
Open
test: prevent root versions.txt from affecting postprocessor test fixtures#12853
Conversation
…tures After the monorepo migration, the shared versions.txt at the root caused Release Please to mutate test fixtures named pom.xml, breaking the postprocessor unit test. - Added -golden suffix to version markers in test resources to isolate them from Release Please scanning. Fixes #12841
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the version update metadata in several test resource POM files by appending '-golden' to the artifact identifiers within the x-version-update comments for Google Cloud DNS, Service Control, and Tasks. I have no feedback to provide.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the monorepo migration, the shared versions.txt at the root caused Release Please to mutate test fixtures named pom.xml, breaking the postprocessor unit test.
Fixes #12841