ci: hermetic build action version to use shared-dependencies verson#12855
ci: hermetic build action version to use shared-dependencies verson#12855
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the update_generation_config.sh script to improve the flexibility of GitHub Action version updates and switches the composite action reference to use the google-cloud-shared-dependencies version. Feedback includes a suggestion to refine the sed regex to prevent accidental deletion of trailing content on a line and a correction for a comment that references the wrong BOM.
The hermetic build script relied on the sdk-platform-java release version to set the GitHub Action verison. Now it's in the monorepo and cannot rely on the version. Instead, let's use the shared dependencies BOM version in the Git tag. b/503444342
suztomo
force-pushed
the
action-tag-using-gapic-libraries-bom
branch
from
fe86ba8 to
55307d8
Compare
|
dorny/paths-filter fails: This is irrelevant to this change. |
Why isn't this working... => Closing and reopening this pull request initiated the check runs. |
|
|
|
cloud-sdk-java-team's approval power is needed. |
| # After the google-cloud-java monorepo migration of sdk-platform-java, | ||
| # we cannot rely on the gapic-generator-java version tag. Let's use | ||
| # the shared dependencies BOM version | ||
| latest_shared_dependencies_bom_version=$(get_latest_released_version "com.google.cloud" "google-cloud-shared-dependencies") |
There was a problem hiding this comment.
Why not use google-cloud-java's version?
There was a problem hiding this comment.
google-cloud-java 's version (gapic-libraries-bom version) is set in the previous cycle for a release. If we need to tweak the Git tag, it's inconvenient. On the other hand, google-cloud-shared-dependencies tag is flexible; we can update the tag.
4 participants
The hermetic build script relied on the sdk-platform-java release version to set the GitHub Action version. Now it's in the monorepo and cannot rely on the version. Instead, let's use the shared dependencies BOM version in the Git tag.
This change will resolve the latest failure in "chore: Update generation configuration" pull requests googleapis/java-bigtable#2894:
where 2.71.0 is the version of the latest gapic-generator-java artifact. We don't have this tag in the google-cloud-java repository.